You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/27 11:16:31 UTC
[GitHub] [cloudstack-go] tetra12 opened a new pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
tetra12 opened a new pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26
This is the fix for #25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010927289
@svanharmelen It looks like the scheme has diverged in 4.16. Definitely need to update the generator code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1083047759
@Pearl1594 is this good to merge, or we need to do any further testing. cc @davidjumani - if this affects any of your work on cks/capc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] kohrar commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
kohrar commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1082301288
Thanks for making this PR. I can confirm that it fixes an issue with the Terraform CloudStack provider when used against CloudStack 4.16 where the provider crashes when trying to parse the VPC output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010989619
@rohityadavcloud Hi Rohid :clap: . Is there anyone in charge of maintaining this project? I'd like to contribute but see noone to be engaged after the the project transfer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1001517586
This is actually a quick and dirty fix, since I'm fixing schema in a generated file :roll_eyes: . I'll be looking :eyes: into this how to properly change the generator code to get a valid generated schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1083059486
@davidjumani good to merge as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] Pearl1594 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1083056704
Yes @rohityadavcloud - it's good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 commented on a change in pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 commented on a change in pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r788773686
##########
File path: cloudstack/VPCService.go
##########
@@ -2855,7 +2855,7 @@ type VPC struct {
JobID string `json:"jobid"`
Jobstatus int `json:"jobstatus"`
Name string `json:"name"`
- Network []string `json:"network"`
+ Network []Network `json:"network"`
Review comment:
Hi @Pearl1594
Thanks for your hint. I updated the generator code as per your advice. Pls check it up again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010926268
@svanharmelen Hello :clap:
Could you pls review my PR? It seems like devs are not active here. Probably due to the knowledge gap in this project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 edited a comment on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 edited a comment on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010989619
@rohityadavcloud Hi Rohit :clap: . Is there anyone in charge of maintaining this project? I'd like to contribute but see noone to be engaged after the the project transfer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010990717
Hi @tetra12 yes, all of ACS committers and PMCs are here to help maintain it; esp. @davidjumani @Pearl1594 (if you see their recent commit/PR activity).
- Rohit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] Pearl1594 commented on a change in pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r783633640
##########
File path: cloudstack/VPCService.go
##########
@@ -2855,7 +2855,7 @@ type VPC struct {
JobID string `json:"jobid"`
Jobstatus int `json:"jobstatus"`
Name string `json:"name"`
- Network []string `json:"network"`
+ Network []Network `json:"network"`
Review comment:
@tetra12 - the change LGTM, but I believe this change would also probably be required at `CreateVPCResponse` (https://github.com/apache/cloudstack-go/blob/main/cloudstack/VPCService.go#L721) and `UpdateVPCResponse` (https://github.com/apache/cloudstack-go/blob/main/cloudstack/VPCService.go#L3172). You could probably add a check in the function named `mapType` (https://github.com/apache/cloudstack-go/blob/main/generate/generate.go#L1849) - to handle this change via the code generator. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] svanharmelen commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
svanharmelen commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1010935657
Hi @tetra12, thanks for reaching out but I'm not actively involved in this project anymore (hence the reason I transferred it). So I guess you need to be patient and wait for someone from the team to pick this up and respond... Sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] tetra12 commented on pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached
Posted by GitBox <gi...@apache.org>.
tetra12 commented on pull request #26:
URL: https://github.com/apache/cloudstack-go/pull/26#issuecomment-1030841504
Anyone alive here ? Is there anyone to merge a PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org