Re: Review Request 19584: CLOUDSTACK-6258: Disable systemvm cloud startup script from logging messages to /var/log/cloud/cloud.out

[Rajani Karuturi <ra...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19584/#review39408
-----------------------------------------------------------



systemvm/patches/debian/config/etc/init.d/cloud
<https://reviews.apache.org/r/19584/#comment71807>

    since the check is about the log file location, i think it should set just that
    
    if()
      LOG_FILE = /var/log/cloud/cloud.out
    else
      LOG_FILE = /dev/null
    
    
    and the actual cmd can be
    
    (cd $CLOUDSTACK_HOME/systemvm; nohup ./run.sh > $LOG_FILE 2>&1 &)


- Rajani Karuturi


On March 24, 2014, 3 p.m., Saurav Lahiri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19584/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 3 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This will prevent the /etc/init.d/cloud script from logging messages to /var/log/cloud/cloud.out if the CLOUD_DEBUG flag is not defined. If the flag is defined only then will messages be logged. This is because the cloud.out file gets rolled over once max size is reached via the log4j settings, since the script is not aware of the log4j settings it causes the log file to exceed its max size and fill up the file system. 
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/etc/init.d/cloud 83853bc 
> 
> Diff: https://reviews.apache.org/r/19584/diff/
> 
> 
> Testing
> -------
> 
> The console proxy vm was started and console sessions tested. The secondary storage vm was succesfully started.
> 
> 
> Thanks,
> 
> Saurav Lahiri
> 
>