[GitHub] [logging-log4j2] mneundorfer commented on a diff in pull request #836: [LOG4J2-1376] Define eid as String instead of int to allow for Oid according to RFC5424

[GitBox <gi...@apache.org>]

mneundorfer commented on code in PR #836:
URL: https://github.com/apache/logging-log4j2/pull/836#discussion_r873376193


##########
log4j-core/src/test/java/org/apache/logging/log4j/core/layout/Rfc5424LayoutTest.java:
##########
@@ -527,4 +532,61 @@ public void testParameterizedMessage() {
             appender.stop();
         }
     }
+
+    @Test
+    void testLayoutBuilder() {
+        for (final Appender appender : root.getAppenders().values()) {
+            root.removeAppender(appender);
+        }
+
+        final AbstractStringLayout layout = new Rfc5424Layout.Rfc5424LayoutBuilder()
+                .setFacility(Facility.LOCAL0)
+                .setId("Event")
+                .setEin("36aaa92")

Review Comment:
   Indeed! I fixed this and rebased the branch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org