You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/05/24 17:59:34 UTC
Review Request 67292: Added warning to Python version checker script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
After the user has installed Python 3, if they use the Python 2
scripts, we want to alert them to start using (and therefore testing)
the ported Python 3 scripts.
Diffs
-----
support/check-python3.py PRE-CREATION
Diff: https://reviews.apache.org/r/67292/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67292: Added warning to Python version checker
script.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/
-----------------------------------------------------------
(Updated May 24, 2018, 3:20 p.m.)
Review request for mesos and Armand Grillet.
Changes
-------
Added underscores.
Repository: mesos
Description
-------
After the user has installed Python 3, if they use the Python 2
scripts, we want to alert them to start using (and therefore testing)
the ported Python 3 scripts.
Diffs (updated)
-----
support/check-python3.py PRE-CREATION
Diff: https://reviews.apache.org/r/67292/diff/2/
Changes: https://reviews.apache.org/r/67292/diff/1-2/
Testing
-------
Non-destructively instructs the user to try the Python 3 scripts.
```
> ./support/apply-reviews.py -r 67285
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
```
```
> ./support/python3/apply-reviews.py -r 67285
2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
```
```
> git commit
Usage: ./mesos-split.py <filename>...
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
On branch python3
```
```
> env MESOSSUPPORTPYTHON=3 git commit
Using Python 3 support scripts to verify what is about to be committed.
No C++ files to lint
No JavaScript files to lint
No Python files to lint
You're using Python 3
```
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67292: Added warning to Python version checker
script.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/#review203801
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67247', '67099', '67282', '67059', '67292']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67292
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67292/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1015 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (752 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (776 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (735 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (759 ms total)
[----------] Global test environment tear-down
[==========] 981 tests from 95 test cases ran. (445090 ms total)
[ PASSED ] 980 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67292/logs/mesos-tests-stderr.log):
```
I0524 19:30:29.764704 19840 master.cpp:10843] Updating the state of task 0bac9c1b-d8b1-4ebb-93b3-6d807febbddc of framework e5c864b0-5e59-44c8-8777-2172fc0c5877-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0524 19:30:29.764704 20852 slave.cpp:3935] Shutting down framework e5c864b0-5e59-44c8-8777-2172fc0c5877-0000
I0524 19:30:29.765713 20852 slave.cpp:6656] Shutting down executor '0bac9c1b-d8b1-4ebb-93b3-6d807febbddc' of framework e5c864b0-5e59-44c8-8777-2172fc0c5877-0000 at executor(1)@192.10.1.6:59881
I0524 19:30:29.766670 20852 slave.cpp:929] Agent terminating
W0524 19:30:29.767705 20852 slave.cpp:3931] Ignoring shutdown framework e5c864b0-5e59-44c8-8777-2172fc0c5877-0000 because it is terminating
I0524 19:30:29.767705 19840 master.cpp:10942] Removing task 0bac9c1b-d8b1-4ebb-93b3-6d807febbddc with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework e5c864b0-5e59-44c8-8777-2172fc0c5877-0000 on agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0 at slave(448)@192.10.1.6:59I0524 19:30:29.596686 21692 exec.cpp:162] Version: 1.7.0
I0524 19:30:29.621783 14796 exec.cpp:236] Executor registered on agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0
I0524 19:30:29.625706 22384 executor.cpp:178] Received SUBSCRIBED event
I0524 19:30:29.630690 22384 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0524 19:30:29.630690 22384 executor.cpp:178] Received LAUNCH event
I0524 19:30:29.635706 22384 executor.cpp:665] Starting task 0bac9c1b-d8b1-4ebb-93b3-6d807febbddc
I0524 19:30:29.718690 22384 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0524 19:30:29.735697 22384 executor.cpp:678] Forked command at 10208
I0524 19:30:29.766670 16644 exec.cpp:445] Executor asked to shutdown
I0524 19:30:29.767705 16764 executor.cpp:178] Received SHUTDOWN event
I0524 19:30:29.767705 16764 executor.cpp:781] Shutting down
I0524 19:30:29.767705 16764 executor.cpp:894] Sending SIGTERM to process tree at pid 10860 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 19:30:29.771683 19840 master.cpp:1293] Agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0 at slave(448)@192.10.1.6:59860 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0524 19:30:29.771683 19840 master.cpp:3303] Disconnecting agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0 at slave(448)@192.10.1.6:59860 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 19:30:29.771683 19916 hierarchical.cpp:344] Removed framework e5c864b0-5e59-44c8-8777-2172fc0c5877-0000
I0524 19:30:29.771683 19840 master.cpp:3322] Deactivating agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0 at slave(448)@192.10.1.6:59860 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 19:30:29.771683 17220 hierarchical.cpp:766] Agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0 deactivated
I0524 19:30:29.771683 13140 containerizer.cpp:2401] Destroying container 87a0879e-170b-48fd-ad1a-f832177319f3 in RUNNING state
I0524 19:30:29.772680 13140 containerizer.cpp:3015] Transitioning the state of container 87a0879e-170b-48fd-ad1a-f832177319f3 from RUNNING to DESTROYING
I0524 19:30:29.773690 13140 launcher.cpp:156] Asked to destroy container 87a0879e-170b-48fd-ad1a-f832177319f3
I0524 19:30:29.844750 20544 containerizer.cpp:2854] Container 87a0879e-170b-48fd-ad1a-f832177319f3 has exited
I0524 19:30:29.873724 20832 master.cpp:1135] Master terminating
I0524 19:30:29.875692 9384 hierarchical.cpp:609] Removed agent e5c864b0-5e59-44c8-8777-2172fc0c5877-S0
I0524 19:30:30.364962 15152 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 24, 2018, 6:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67292/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 6:58 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the user has installed Python 3, if they use the Python 2
> scripts, we want to alert them to start using (and therefore testing)
> the ported Python 3 scripts.
>
>
> Diffs
> -----
>
> support/check-python3.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67292/diff/1/
>
>
> Testing
> -------
>
> Non-destructively instructs the user to try the Python 3 scripts.
>
> ```
> > ./support/apply-reviews.py -r 67285
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
> ```
>
> ```
> > ./support/python3/apply-reviews.py -r 67285
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
> ```
>
> ```
> > git commit
> Usage: ./mesos-split.py <filename>...
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> On branch python3
> ```
>
> ```
> > env MESOSSUPPORTPYTHON=3 git commit
> Using Python 3 support scripts to verify what is about to be committed.
> No C++ files to lint
> No JavaScript files to lint
> No Python files to lint
> You're using Python 3
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67292: Added warning to Python version checker
script.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/#review203816
-----------------------------------------------------------
support/check-python3.py
Lines 37 (patched)
<https://reviews.apache.org/r/67292/#comment286129>
Please change to be `MESOS_SUPPORT_PYTHON`.
support/check-python3.py
Lines 38 (patched)
<https://reviews.apache.org/r/67292/#comment286128>
Please change to be `MESOS_SUPPORT_PYTHON`.
- Armand Grillet
On May 24, 2018, 6:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67292/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 6:58 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the user has installed Python 3, if they use the Python 2
> scripts, we want to alert them to start using (and therefore testing)
> the ported Python 3 scripts.
>
>
> Diffs
> -----
>
> support/check-python3.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67292/diff/1/
>
>
> Testing
> -------
>
> Non-destructively instructs the user to try the Python 3 scripts.
>
> ```
> > ./support/apply-reviews.py -r 67285
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
> ```
>
> ```
> > ./support/python3/apply-reviews.py -r 67285
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
> ```
>
> ```
> > git commit
> Usage: ./mesos-split.py <filename>...
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> On branch python3
> ```
>
> ```
> > env MESOSSUPPORTPYTHON=3 git commit
> Using Python 3 support scripts to verify what is about to be committed.
> No C++ files to lint
> No JavaScript files to lint
> No Python files to lint
> You're using Python 3
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67292: Added warning to Python version checker
script.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/#review203812
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On May 24, 2018, 6:58 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67292/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 6:58 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After the user has installed Python 3, if they use the Python 2
> scripts, we want to alert them to start using (and therefore testing)
> the ported Python 3 scripts.
>
>
> Diffs
> -----
>
> support/check-python3.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67292/diff/1/
>
>
> Testing
> -------
>
> Non-destructively instructs the user to try the Python 3 scripts.
>
> ```
> > ./support/apply-reviews.py -r 67285
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
> ```
>
> ```
> > ./support/python3/apply-reviews.py -r 67285
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
> ```
>
> ```
> > git commit
> Usage: ./mesos-split.py <filename>...
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> On branch python3
> ```
>
> ```
> > env MESOSSUPPORTPYTHON=3 git commit
> Using Python 3 support scripts to verify what is about to be committed.
> No C++ files to lint
> No JavaScript files to lint
> No Python files to lint
> You're using Python 3
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67292: Added warning to Python version checker
script.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/
-----------------------------------------------------------
(Updated May 24, 2018, 11:58 a.m.)
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
After the user has installed Python 3, if they use the Python 2
scripts, we want to alert them to start using (and therefore testing)
the ported Python 3 scripts.
Diffs
-----
support/check-python3.py PRE-CREATION
Diff: https://reviews.apache.org/r/67292/diff/1/
Testing (updated)
-------
Non-destructively instructs the user to try the Python 3 scripts.
```
> ./support/apply-reviews.py -r 67285
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
```
```
> ./support/python3/apply-reviews.py -r 67285
2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] -> "67285.patch" [1]
```
```
> git commit
Usage: ./mesos-split.py <filename>...
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
On branch python3
```
```
> env MESOSSUPPORTPYTHON=3 git commit
Using Python 3 support scripts to verify what is about to be committed.
No C++ files to lint
No JavaScript files to lint
No Python files to lint
You're using Python 3
```
Thanks,
Andrew Schwartzmeyer