[GitHub] [pinot] yuanbenson commented on a diff in pull request #10645: SegmentTarPushJobRunner shouldn't fail with missing pushJobSpec

["yuanbenson (via GitHub)" <gi...@apache.org>]

yuanbenson commented on code in PR #10645:
URL: https://github.com/apache/pinot/pull/10645#discussion_r1171657164


##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/BaseSegmentPushJobRunner.java:
##########
@@ -50,12 +50,19 @@ public abstract class BaseSegmentPushJobRunner implements IngestionJobRunner {
 
   /**
    * Initialize BaseSegmentPushJobRunner with SegmentGenerationJobSpec
-   * Checks for required parameters in the spec and enablement of consistent data push.
    */
   @Override
   public void init(SegmentGenerationJobSpec spec) {
+    init(spec, true);
+  }
+
+  /**
+   * Initialize BaseSegmentPushJobRunner with SegmentGenerationJobSpec
+   * Checks for required parameters in the spec and enablement of consistent data push.
+   */
+  public void init(SegmentGenerationJobSpec spec, boolean checkPushJobSpec) {

Review Comment:
   Done. 
   1. Kept `tableSpec` as required as a NPE will happen downstream if not supplied.
   2. Made fix to have `tableSpec.tableConfigURI` as optional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org