[GitHub] [httpcomponents-core] chrysophylax commented on a diff in pull request #435: HTTPCORE-759 Content-Length missing on null entity request content

["chrysophylax (via GitHub)" <gi...@apache.org>]

chrysophylax commented on code in PR #435:
URL: https://github.com/apache/httpcomponents-core/pull/435#discussion_r1341265651


##########
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##########
@@ -110,6 +110,10 @@ public void process(final HttpRequest request, final EntityDetails entity, final
                 throw new ProtocolException("Content-Length header already present");
             }
         }
+        if (entity == null) {

Review Comment:
   Isn't a HttpEntityEnclosingRequest inherently only for these methods which the standard defines Enclosed Content semantics? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org