You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/22 17:23:44 UTC
[GitHub] [echarts] TailorDone opened a new issue, #17548: [Bug] emptyCircle series symbol fill defaults to white (dark mode problem)
TailorDone opened a new issue, #17548:
URL: https://github.com/apache/echarts/issues/17548
### Version
5.3.2
### Link to Minimal Reproduction
https://codesandbox.io/s/interesting-bouman-e85bk3
### Steps to Reproduce
Link above should show issue. No additional work needed. Otherwise, here are some options to test.
Option 1:
1. Create a line chart
2. The default symbol for line chart is `emptyCircle`. If it for some reason doesn't show, you can set the series symbol to `emptyCircle`
3. Set your background color to a darker color or switch to dark mode
Option 2:
1. Go to the echarts line-chart example (https://echarts.apache.org/examples/en/editor.html?c=line-simple)
2. Turn on dark mode. Notice that empty circle is now defaulted to circle
3. Under series, add the following code
`symbol: 'emptyCircle',
symbolSize: 10,`
### Current Behavior
The fill color is set to white. This looks particularly bad with dark mode
### Expected Behavior
I would expect the word 'empty' to have no fill color associated with it, and therefor could be used regardless of the chart background color.
### Environment
```markdown
- OS: macOS Monterey v12.4
- Browser: Chrome 104.0.5112.101
- Framework: React@17
```
### Any additional comments?
Looking in the code I found the following where any symbol with `empty` sets the fill color to white. https://github.com/apache/echarts/blob/db866d8e70098ac1d2349b9bc4c5bd0eee539dcc/src/chart/line/LineSeries.ts#L258-L262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [I] [Bug] emptyCircle series symbol fill defaults to white (dark mode problem) [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #17548: [Bug] emptyCircle series symbol fill defaults to white (dark mode problem)
URL: https://github.com/apache/echarts/issues/17548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [I] [Bug] emptyCircle series symbol fill defaults to white (dark mode problem) [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #17548:
URL: https://github.com/apache/echarts/issues/17548#issuecomment-2305635689
This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #17548: [Bug] emptyCircle series symbol fill defaults to white (dark mode problem)
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #17548:
URL: https://github.com/apache/echarts/issues/17548#issuecomment-1223937915
Please use `circle` instead of `emptyCircle` and you can set its `color` and `borderColor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [I] [Bug] emptyCircle series symbol fill defaults to white (dark mode problem) [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #17548:
URL: https://github.com/apache/echarts/issues/17548#issuecomment-2322334868
This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org