You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2012/12/11 18:52:04 UTC
[Bug 54282] New: [PATCH] Fix to speed up opening xslx spreadsheets
https://issues.apache.org/bugzilla/show_bug.cgi?id=54282
Bug ID: 54282
Summary: [PATCH] Fix to speed up opening xslx spreadsheets
Product: POI
Version: 3.9-dev
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: XSSF
Assignee: dev@poi.apache.org
Reporter: jan.stette@gmail.com
Classification: Unclassified
Created attachment 29744
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29744&action=edit
Patch for avoiding repeated calls to size function
I'm seeing Apache POI being very slow when opening certain xslx/XSSF
spreadsheets. After profiling, it turns out that around half the time was spent
calling CTColsImpl.sizeOfColArray() inside ColumnHelper.addCleanColIntoCols().
See the attached screenshot from my profiler session.
The fix is trivially simple, it just pulls the call to sizeOfColArray() outside
of the loop. On some spreadsheets, this reduces the time of loading the
spreadsheet to half of the original time.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54282] [PATCH] Fix to speed up opening xslx spreadsheets
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54282
Jan <ja...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29744|0 |1
is patch| |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54282] [PATCH] Fix to speed up opening xslx spreadsheets
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54282
--- Comment #1 from Jan <ja...@gmail.com> ---
Created attachment 29745
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29745&action=edit
Screenshot from profiler session showing bottleneck
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54282] [PATCH] Fix to speed up opening xslx spreadsheets
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54282
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Nick Burch <ap...@gagravarr.org> ---
Thanks for this, committed in r1420501.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 54282] [PATCH] Fix to speed up opening xslx spreadsheets
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54282
Warwick <wa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |warwick_burrows@yahoo.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org