You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/11/05 19:15:48 UTC

[GitHub] [incubator-livy] wypoon commented on a change in pull request #253: [LIVY-705][THRIFT] Support getting keystore password from Hadoop credential provider

wypoon commented on a change in pull request #253: [LIVY-705][THRIFT] Support getting keystore password from Hadoop credential provider
URL: https://github.com/apache/incubator-livy/pull/253#discussion_r342748199
 
 

 ##########
 File path: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftCLIService.scala
 ##########
 @@ -83,6 +84,22 @@ abstract class ThriftCLIService(val cliService: LivyCLIService, val serviceName:
     super.init(livyConf)
   }
 
+  protected def getKeyStorePassword(): String = {
+    val credentialProviderPath = livyConf.get(LivyConf.HADOOP_CREDENTIAL_PROVIDER_PATH)
 
 Review comment:
   Sure, I can do that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services