[GitHub] [pulsar] eolivelli commented on a change in pull request #11905: Fixed KCA Sink handling of Json and Avro; support for kafka connectors that overload task.preCommit() directly

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11905:
URL: https://github.com/apache/pulsar/pull/11905#discussion_r702302900



##########
File path: pulsar-io/kafka-connect-adaptor/src/test/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSinkTest.java
##########
@@ -390,7 +454,7 @@ public void unknownRecordSchemaTest() throws Exception {
     @Test
     public void KeyValueSchemaTest() throws Exception {
         KeyValue<Integer, String> kv = new KeyValue<>(11, "value");
-        recordSchemaTest(kv, Schema.KeyValue(Schema.INT32, Schema.STRING), 11, "INT32", "value", "STRING");
+        SinkRecord sinkRecord = recordSchemaTest(kv, Schema.KeyValue(Schema.INT32, Schema.STRING), 11, "INT32", "value", "STRING");

Review comment:
       Did you want to add some assertion around this unused variable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org