You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/31 11:27:47 UTC

[GitHub] ashb commented on a change in pull request #4556: [AIRFLOW-3730] Standarization use of logs mechanisms

ashb commented on a change in pull request #4556: [AIRFLOW-3730] Standarization use of logs mechanisms
URL: https://github.com/apache/airflow/pull/4556#discussion_r252630284
 
 

 ##########
 File path: airflow/contrib/hooks/ssh_hook.py
 ##########
 @@ -27,10 +27,9 @@
 
 from airflow.exceptions import AirflowException
 from airflow.hooks.base_hook import BaseHook
-from airflow.utils.log.logging_mixin import LoggingMixin
 
 
-class SSHHook(BaseHook, LoggingMixin):
+class SSHHook(BaseHook):
 
 Review comment:
   These aren't needed because BaseHook already does this, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services