You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Francesco Chicchiriccò <no...@github.com> on 2015/03/12 13:54:04 UTC
[jclouds-labs] [JCLOUDS-841] AffinityGroups operations implemented
(#150)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/150
-- Commit Summary --
* [JCLOUDS-841] AffinityGroups operations implemented
-- File Changes --
M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java (9)
A azurecompute/src/main/java/org/jclouds/azurecompute/binders/CreateAffinityGroupParamsToXML.java (50)
M azurecompute/src/main/java/org/jclouds/azurecompute/binders/StorageServiceParamsToXML.java (3)
A azurecompute/src/main/java/org/jclouds/azurecompute/binders/UpdateAffinityGroupParamsToXML.java (50)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/AffinityGroup.java (137)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CreateAffinityGroupParams.java (115)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/UpdateAffinityGroupParams.java (84)
A azurecompute/src/main/java/org/jclouds/azurecompute/features/AffinityGroupApi.java (122)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/AffinityGroupHandler.java (136)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ComputeCapabilitiesHandler.java (87)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListAffinityGroupsHandler.java (76)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/AffinityGroupApiLiveTest.java (94)
A azurecompute/src/test/java/org/jclouds/azurecompute/features/AffinityGroupApiMockTest.java (100)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/DiskApiLiveTest.java (25)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/LocationApiLiveTest.java (7)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/OSImageApiLiveTest.java (21)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/SubscriptionApiLiveTest.java (7)
A azurecompute/src/test/java/org/jclouds/azurecompute/internal/AbstractAzureComputeApiLiveTest.java (47)
M azurecompute/src/test/java/org/jclouds/azurecompute/internal/BaseAzureComputeApiLiveTest.java (32)
A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListAffinityGroupsHandlerTest.java (90)
A azurecompute/src/test/resources/affinityGroups.xml (45)
A azurecompute/src/test/resources/createaffinitygroupparams.xml (1)
A azurecompute/src/test/resources/updateaffinitygroupparams.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/150.patch
https://github.com/jclouds/jclouds-labs/pull/150.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150
Re: [jclouds-labs] [JCLOUDS-841] AffinityGroups operations
implemented (#150)
Posted by Ignasi Barrera <no...@github.com>.
Thanks @ilgrosso! Can you squash the commits so I can cleanly merge the it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150#issuecomment-88236170
Re: [jclouds-labs] [JCLOUDS-841] AffinityGroups operations
implemented (#150)
Posted by Ignasi Barrera <no...@github.com>.
> + final String requestId = api().add(params);
> + assertTrue(operationSucceeded.apply(requestId), requestId);
> + }
> +
> + @Test(dependsOnMethods = "testCreate")
> + public void testUpdate() {
> + final UpdateAffinityGroupParams params = UpdateAffinityGroupParams.builder().
> + description(GROUP_NAME + " description").
> + build();
> +
> + final String requestId = api().update(GROUP_NAME, params);
> + assertTrue(operationSucceeded.apply(requestId), requestId);
> + }
> +
> + @Test(dependsOnMethods = "testUpdate")
> + public void testDelete() throws Exception {
Should this better be an `@AfterClass` so we also delete the group if the update test fails?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150/files#r26705011
Re: [jclouds-labs] [JCLOUDS-841] AffinityGroups operations
implemented (#150)
Posted by Ignasi Barrera <no...@github.com>.
Just a couple minors. lgtm! Thanks @ilgrosso. Once addressed we'll have to wait until 1.9.0 is released to merge this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150#issuecomment-83163466
Re: [jclouds-labs] [JCLOUDS-841] AffinityGroups operations
implemented (#150)
Posted by Francesco Chicchiriccò <no...@github.com>.
Thx for reviewing @nacx - the additional commit should address your review, please let me know.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150#issuecomment-83484020
Re: [jclouds-labs] [JCLOUDS-841] AffinityGroups operations
implemented (#150)
Posted by Ignasi Barrera <no...@github.com>.
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d928dbcc) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/15fcd411). Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150#issuecomment-88416897
Re: [jclouds-labs] [JCLOUDS-841] AffinityGroups operations
implemented (#150)
Posted by Ignasi Barrera <no...@github.com>.
> + }
> +
> + public void testDelete() throws Exception {
> + MockWebServer server = mockAzureManagementServer();
> + server.enqueue(requestIdResponse("request-3"));
> +
> + try {
> + final AffinityGroupApi api = api(server.getUrl("/")).getAffinityGroupApi();
> +
> + assertEquals(api.delete("mygroup"), "request-3");
> +
> + assertSent(server, "DELETE", "/affinitygroups/mygroup");
> + } finally {
> + server.shutdown();
> + }
> + }
Add mock tests that exercise the fallbacks you explicitly define in the API class.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150/files#r26705043