You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/04/23 09:59:54 UTC
[GitHub] [yunikorn-site] zhuqi-lucas opened a new pull request, #289: [YUNIKORN-1383] [website] REST API doc changes in Yunikorn Website
zhuqi-lucas opened a new pull request, #289:
URL: https://github.com/apache/yunikorn-site/pull/289
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on a diff in pull request #289: [YUNIKORN-1383] [website] REST API doc changes in Yunikorn Website
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #289:
URL: https://github.com/apache/yunikorn-site/pull/289#discussion_r1189261321
##########
docs/api/scheduler.md:
##########
@@ -681,6 +681,353 @@ Fetch an Application given a Partition, Queue and Application ID and displays ge
}
```
+## UsersTracker
+### Get users usage tracking information
+
+Fetch all users usage given a Partition and displays general information about the users managed by YuniKorn.
+
+**URL** : `/ws/v1/partition/{partitionName}/usage/users`
+
+**Method** : `GET`
+
+**Auth required** : NO
+
+### Success response
+
+**Code** : `200 OK`
+
+**Content example**
+
+```json
+[
+ {
+ "userName": "user1",
+ "groups": {
+ "app2": "tester"
+ },
+ "queues":
+ {
+ "queuename": "root",
Review Comment:
This is not correct in the example output and should be fixed, it really is `queuePath`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #289: [YUNIKORN-1383] [website] REST API doc changes in Yunikorn Website
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #289:
URL: https://github.com/apache/yunikorn-site/pull/289#discussion_r1188560400
##########
docs/api/scheduler.md:
##########
@@ -681,6 +681,353 @@ Fetch an Application given a Partition, Queue and Application ID and displays ge
}
```
+## UsersTracker
+### Get users usage tracking information
+
+Fetch all users usage given a Partition and displays general information about the users managed by YuniKorn.
+
+**URL** : `/ws/v1/partition/{partitionName}/usage/users`
+
+**Method** : `GET`
+
+**Auth required** : NO
+
+### Success response
+
+**Code** : `200 OK`
+
+**Content example**
+
+```json
+[
+ {
+ "userName": "user1",
+ "groups": {
+ "app2": "tester"
+ },
+ "queues":
+ {
+ "queuename": "root",
Review Comment:
Hi @zhuqi-lucas .
Based on https://github.com/apache/yunikorn-core/blob/master/pkg/webservice/dao/ugm_info.go, "queuename" should be "queuePath" in this example.
Did you modify the ugm_info.go locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] zhuqi-lucas commented on pull request #289: [YUNIKORN-1383] [website] REST API doc changes in Yunikorn Website
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #289:
URL: https://github.com/apache/yunikorn-site/pull/289#issuecomment-1541271517
Thank you @wilfred-s @0yukali0 for review, addressed the comments in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] 0yukali0 merged pull request #289: [YUNIKORN-1383] [website] REST API doc changes in Yunikorn Website
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 merged PR #289:
URL: https://github.com/apache/yunikorn-site/pull/289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org