You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/01/30 03:16:22 UTC

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441 

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17011


Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................

IMPALA-10459: Remove workarounds for MAPREDUCE-6441

MAPREDUCE-6441 is resolved and is in our toolchain. This patch removes
workarounds for it.

Tests:
 - Ran exhaustive test.

Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
---
M bin/load-data.py
M fe/src/test/java/org/apache/impala/catalog/events/EventsProcessorStressTest.java
M fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java
M tests/common/impala_test_suite.py
4 files changed, 28 insertions(+), 75 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17011/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8069/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 02:23:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 1:

(4 comments)

Hi Quanlong, found some nits, aside from those LGTM!

http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py
File bin/load-data.py:

http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py@29
PS1, Line 29: import shutil
nit: this becomes unused with this change


http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py@33
PS1, Line 33: import tempfile
nit: this becomes unused with this change


http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py@30
PS1, Line 30: import shutil
nit: this becomes unused with this change


http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py@33
PS1, Line 33: import tempfile
nit: this becomes unused with this change



-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Feb 2021 09:22:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 2:

(4 comments)

> Patch Set 1:
> 
> (4 comments)
> 
> Hi Quanlong, found some nits, aside from those LGTM!

Thanks for catching up this!

http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py
File bin/load-data.py:

http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py@29
PS1, Line 29: import sqlpar
> nit: this becomes unused with this change
Done


http://gerrit.cloudera.org:8080/#/c/17011/1/bin/load-data.py@33
PS1, Line 33: import tracebac
> nit: this becomes unused with this change
Done


http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py@30
PS1, Line 30: import socket
> nit: this becomes unused with this change
Done


http://gerrit.cloudera.org:8080/#/c/17011/1/tests/common/impala_test_suite.py@33
PS1, Line 33: from functools 
> nit: this becomes unused with this change
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 02:02:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 2:

Ran exhaustive test on PS2 and it passed: https://jenkins.impala.io/job/pre-review-test/835/


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 00:59:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 06:35:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................

IMPALA-10459: Remove workarounds for MAPREDUCE-6441

MAPREDUCE-6441 is resolved and is in our toolchain. This patch removes
workarounds for it.

Tests:
 - Ran exhaustive test.

Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Reviewed-on: http://gerrit.cloudera.org:8080/17011
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/load-data.py
M fe/src/test/java/org/apache/impala/catalog/events/EventsProcessorStressTest.java
M fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java
M tests/common/impala_test_suite.py
4 files changed, 28 insertions(+), 80 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6872/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 01:00:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 2: Code-Review+2

This makes sense to me, thanks for taking it on!


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 22:34:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 11:18:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Tamas Mate, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17011

to look at the new patch set (#2).

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................

IMPALA-10459: Remove workarounds for MAPREDUCE-6441

MAPREDUCE-6441 is resolved and is in our toolchain. This patch removes
workarounds for it.

Tests:
 - Ran exhaustive test.

Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
---
M bin/load-data.py
M fe/src/test/java/org/apache/impala/catalog/events/EventsProcessorStressTest.java
M fe/src/test/java/org/apache/impala/util/RandomHiveQueryRunner.java
M tests/common/impala_test_suite.py
4 files changed, 28 insertions(+), 80 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17011/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8054/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 Jan 2021 03:38:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 )

Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4d482a6d15cdc08e9cf8878e130399665a8ee0
Gerrit-Change-Number: 17011
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Feb 2021 01:00:14 +0000
Gerrit-HasComments: No