You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/07/20 02:14:55 UTC
[kudu-CR] test: deflake ksck remote-test TestChecksumSnapshotCurrentTimestamp
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13887
Change subject: test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
......................................................................
test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
I saw a failure of the test with the following error:
W0720 00:44:31.890009 4561 tablet_service.cc:2357] Rejecting scan request for tablet 9542a9eebae84c1b993235a309c866d0: Uninitialized: safe time has not yet been initialized
/data0/jenkins/workspace/kudu-pre-commit-unittest-ASAN/src/kudu/tools/ksck_remote-test.cc:451: Failure
Failed
Bad status: Aborted: 1 errors were detected
This patch wraps the checksum with an ASSERT_EVENTUALLY, since the scan
should eventually pass once a leader is elected or writes succeed.
Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
---
M src/kudu/tools/ksck_remote-test.cc
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/13887/1
--
To view, visit http://gerrit.cloudera.org:8080/13887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
Gerrit-Change-Number: 13887
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] test: deflake ksck remote-test TestChecksumSnapshotCurrentTimestamp
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13887 )
Change subject: test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
Gerrit-Change-Number: 13887
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 23 Aug 2019 20:24:55 +0000
Gerrit-HasComments: No
[kudu-CR] test: deflake ksck remote-test TestChecksumSnapshotCurrentTimestamp
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13887 )
Change subject: test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
......................................................................
test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
I saw a failure of the test with the following error:
W0720 00:44:31.890009 4561 tablet_service.cc:2357] Rejecting scan request for tablet 9542a9eebae84c1b993235a309c866d0: Uninitialized: safe time has not yet been initialized
/data0/jenkins/workspace/kudu-pre-commit-unittest-ASAN/src/kudu/tools/ksck_remote-test.cc:451: Failure
Failed
Bad status: Aborted: 1 errors were detected
This patch wraps the checksum with an ASSERT_EVENTUALLY, since the scan
should eventually pass once a leader is elected or writes succeed.
Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
Reviewed-on: http://gerrit.cloudera.org:8080/13887
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/tools/ksck_remote-test.cc
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
Gerrit-Change-Number: 13887
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] test: deflake ksck remote-test TestChecksumSnapshotCurrentTimestamp
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13887
to look at the new patch set (#2).
Change subject: test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
......................................................................
test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp
I saw a failure of the test with the following error:
W0720 00:44:31.890009 4561 tablet_service.cc:2357] Rejecting scan request for tablet 9542a9eebae84c1b993235a309c866d0: Uninitialized: safe time has not yet been initialized
/data0/jenkins/workspace/kudu-pre-commit-unittest-ASAN/src/kudu/tools/ksck_remote-test.cc:451: Failure
Failed
Bad status: Aborted: 1 errors were detected
This patch wraps the checksum with an ASSERT_EVENTUALLY, since the scan
should eventually pass once a leader is elected or writes succeed.
Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
---
M src/kudu/tools/ksck_remote-test.cc
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/13887/2
--
To view, visit http://gerrit.cloudera.org:8080/13887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51aeaebca599697e444b244ae15259dea4dbe949
Gerrit-Change-Number: 13887
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)