[GitHub] [hive] pvary commented on a diff in pull request #3277: Hive 21160 rewrite update to multiinsert refactor

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3277:
URL: https://github.com/apache/hive/pull/3277#discussion_r880144671


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -235,6 +236,10 @@ public static String[] selectedColumns(Configuration conf) {
     return readColumns.split(conf.get(serdeConstants.COLUMN_NAME_DELIMITER, String.valueOf(SerDeUtils.COMMA)));
   }
 
+  public static boolean fetchVirtualColumns(Configuration conf) {

Review Comment:
   Should we store this on table level, instead of globally?
   If there is a query reading an iceberg table, and deleting from another table, then we do not need to read the virtual columns for the table we are just reading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org