[GitHub] [doris] github-actions[bot] commented on a diff in pull request #19177: [opt](FileCache) add http api to get file cache metrics

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #19177:
URL: https://github.com/apache/doris/pull/19177#discussion_r1179843178


##########
be/src/io/cache/block/block_lru_file_cache.h:
##########
@@ -126,6 +126,10 @@ class LRUFileCache final : public IFileCache {
     LRUQueue _normal_queue;
     LRUQueue _disposable_queue;
 
+    Statistics get_cache_statistics() override;
+
+    virtual size_t try_release() override;

Review Comment:
   warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
   
   ```suggestion
       size_t try_release() override;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org