You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/10/15 12:48:29 UTC
[GitHub] spark pull request #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to ca...
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/22726
[SPARK-25727][FOLLOWUP] Move outputOrdering to case class field for InMemoryRelation
## What changes were proposed in this pull request?
The PR addresses [the comment](https://github.com/apache/spark/pull/22715#discussion_r225024084) in the previous one. `outputOrdering` becomes a field of `InMemoryRelation`.
## How was this patch tested?
existing UTs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-25727_followup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22726
----
commit b74f4d592b111da54cb62a90e1d06c84ffd7142b
Author: Marco Gaido <ma...@...>
Date: 2018-10-15T11:59:56Z
[SPARK-25727][FOLLOWUP] Move outputOrdering to case class field for InMemoryRelation
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22726
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22726
**[Test build #97392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97392/testReport)** for PR 22726 at commit [`b74f4d5`](https://github.com/apache/spark/commit/b74f4d592b111da54cb62a90e1d06c84ffd7142b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22726
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3984/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22726
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97392/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22726
cc @cloud-fan @dongjoon-hyun @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22726: [SPARK-25727][FOLLOWUP] Move outputOrdering to case clas...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22726
**[Test build #97392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97392/testReport)** for PR 22726 at commit [`b74f4d5`](https://github.com/apache/spark/commit/b74f4d592b111da54cb62a90e1d06c84ffd7142b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org