You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/22 14:44:09 UTC

[GitHub] [druid] abhishekagarwal87 commented on pull request #10366: Add caching support to join queries

abhishekagarwal87 commented on pull request #10366:
URL: https://github.com/apache/druid/pull/10366#issuecomment-696768403


   > Hi @abhishekagarwal87, thanks for the PR. The overall design to compute cache key for hash join looks reasonable to me. I left some comments on details.
   > 
   > You mentioned that unit tests should be added for `CachingQueryRunner` in the PR description. Are you planning to do it in this PR? I think it would be nice to do together in a same PR. Also, please add some for `CachingClusteredClient` as well.
   
   Hi @jihoonson - I have added these tests. I had to refactor `CachingClusteredClient` somewhat to unit test the cache key related pieces. Same goes for `CachingQueryRunner`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org