[jira] [Commented] (FINERACT-702) Integrate SpotBugs and fail build if equals but not hashCode is implemented

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013050#comment-17013050 ] 

Michael Vorburger commented on FINERACT-702:
--------------------------------------------

Setting Fix Version to 1.4.0, as Awasum Yannick did this in [https://github.com/apache/fineract/pull/670/] .. I'm just re-reviewing it, and this is going into 1.4.0.

> Integrate SpotBugs and fail build if equals but not hashCode is implemented
> ---------------------------------------------------------------------------
>
>                 Key: FINERACT-702
>                 URL: https://issues.apache.org/jira/browse/FINERACT-702
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Assignee: Awasum Yannick
>            Priority: Major
>              Labels: starter
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This project should activate SpotBugs (the successor to FindBugs) and make it fail the build for any violations to a at least a subset of rules which are almost always guaranteed to be bugs.
> For example, https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#he-class-defines-equals-and-uses-object-hashcode-he-equals-use-hashcode which would have caught what I manually spotted (but shouldn't have to) in https://github.com/apache/fineract/pull/524.
> FINERACT-402 has some history, but it's clearly not activated to enforce.
> FINERACT-696 could then be built on top of this.
> [~myrle] perhaps you know of any volunteer interested in doing this?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)