You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "ClaireLytt (via GitHub)" <gi...@apache.org> on 2026/08/06 14:40:54 UTC

[PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

ClaireLytt opened a new pull request, #11675:
URL: https://github.com/apache/seatunnel/pull/11675

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   Before working on the Iceberg connector changes for #11007, I reviewed the connector and found the source/sink OptionRules were out of sync with the docs and with the options each side actually reads. This small, self-contained PR fixes them ahead. No new feature behavior, no public option key/default change.
   
   main changes:
   
   - `IcebergSourceFactory`: add `query` to the source rule — it is documented and read when building the source config, but was missing. Move `catalog_name` and `namespace` from required to optional — both have default value `"default"`, so the required declaration was a no-op (ConfigValidator skips options with defaults) and misleading in the exported option metadata.
   - `IcebergSinkFactory`: move `catalog_name`, `namespace` and `table` from required to optional — the first two have defaults, and `table` falls back to the upstream table name when absent (see `renameCatalogTable`), so none of them is actually required.
   - docs (en/zh, source/sink): change `catalog_name`/`namespace`/`table` from required `yes` to `no`, document their defaults, and document the sink `table` fallback-to-upstream-table-name behavior, so the docs match the actual behavior and the rule.
   - strengthen `IcebergFactoryTest`: replace the single `assertNotNull` with assertions on rule contents (`query` present, `catalog_props` still required, `table`/`table_list` exclusivity) plus ConfigValidator accept/reject cases covering single-table, multi-table and sink-without-table configs.
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   No runtime/job behavior change. Conforming configs that follow the docs are unaffected. Only the exported option metadata (required → optional) and the docs change, both now reflecting the actual behavior.
   
   ### How was this patch tested?
   
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   Scoped to the connector-iceberg module (the only module this PR changes):
   
   - `./mvnw spotless:check -pl seatunnel-connectors-v2/connector-iceberg` pass.
   - `./mvnw test -pl seatunnel-connectors-v2/connector-iceberg -Dtest=IcebergFactoryTest` → 14/14, 0 failures
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5229861599

   > Hi @ClaireLytt, thanks for flagging this — I dug into the actual CI runs for the current head ([a33a9ba](https://github.com/apache/seatunnel/commit/a33a9ba27c4c6926928685f58fb3cbd23297ff27)) on both attempts before replying, rather than going off the check summary alone.嗨,感谢您指出这一点。在回复之前,我仔细查看了当前代码分支在两次提交过程中的实际构建结果,而不仅仅是参考了检查总结而已。
   > 
   > Good news: I don't see any real CheckpointPlanTest / TaskTest failures for this PR. Specifically:好消息是:在这次提交中,我没有发现任何与 CheckpointPlanTest 或 TaskTest 相关的故障。具体来说:
   > 
   > * Attempt 1 (finished 2026-08-07 12:48 UTC): in the `unit-test (8, ubuntu-latest)` job log, `org.apache.seatunnel.engine.server.checkpoint.CheckpointPlanTest` ran with `Tests run: 1, Failures: 0, Errors: 0`, and `org.apache.seatunnel.engine.server.dag.TaskTest` ran with `Tests run: 3, Failures: 0, Errors: 0`. Both are clean passes through the `AbstractSeaTunnelServerTest` Hazelcast setup, no errors in `before()` or anywhere else.第一次尝试(完成于 2026 年 8 月 7 日 12:48 UTC):在 `unit-test (8, ubuntu-latest)` 任务日志中, `org.apache.seatunnel.engine.server.checkpoint.CheckpointPlanTest` 与 `Tests run: 1, Failures: 0, Errors: 0` 配合运行, `org.apache.seatunnel.engine.server.dag.TaskTest` 则与 `Tests run: 3, Failures: 0, Errors: 0` 配合运行。两者都在 `AbstractSeaTunnelServerTest` Hazelcast 环境中顺利通过了测试, `before()` 及其他环节均未出现任何错误。
   > * The only non-passing job in attempt 1 was `unit-test (11, windows-latest)`, which failed — but that's unrelated to Checkpoint/Task tests too.在第一次尝试中,唯一没有通过测试的任务是 `unit-test (11, windows-latest)` ,该任务失败了——不过这与检查点/任务测试本身并无关联。
   > * Attempt 2 (the rerun, finished 2026-08-08 08:07 UTC) is fully green on every unit-test job, including `unit-test (11, windows-latest)`, which passed on retry — consistent with that being a flaky/transient failure rather than anything real.第二次尝试(即重新运行后的结果,完成时间为 2026 年 8 月 8 日 08:07 UTC)中,所有单元测试都通过了,包括 `unit-test (11, windows-latest)` 。这说明这次失败只是偶发性的/暂时的问题,而非真正的故障。
   > 
   > The one job that is still not green in either attempt is `Run / Build website` (the docusaurus docs-site build), which hangs for well over an hour and then gets cancelled — that's what's making the overall `Build` check on the apache side show as failed/cancelled. That's unrelated to the Hazelcast/engine test setup and unrelated to the Iceberg connector code in this PR; it looks like an infra/docs-build flakiness issue on the CI side, not something introduced by your change.在这两次尝试中,唯一仍然无法成功完成的任务是 `Run / Build website` (Docusaurus 文档网站的构建)。该任务会持续运行一个多小时,之后就会取消。正是由于这个原因,Apache 端的 `Build` 检查才会显示为“失败/已取消”。这与 Hazelcast/引擎的测试设置无关,也与本次提交中的 Iceberg 连接器代码无关。看来,这是 CI 系统在处理文档构建时的问题,而非你所做的更改所导致的。
   > 
   > So from my side there's nothing in `CheckpointPlanTest`/`TaskTest`/`AbstractSeaTunnelServerTest` that needs fixing here, and it doesn't block this PR. If you're still seeing those specific test failures locally or in a different run, could you share the run URL or the actual failure stack trace? I'm happy to take another look, but I couldn't reproduce or find evidence of that failure in this PR's CI history. My prior approval stands either way.就我而言, `CheckpointPlanTest` / `TaskTest` / `AbstractSeaTunnelServerTest` 中没有任何需要修复的问题,这些问题也不会阻碍此次 PR 的提交。如果您仍然在本地或其他测试环境中遇到这些故障,请分享一下相关的测试 URL 或详细的故障堆栈跟踪信息。我很乐意再检查一遍,但在本次 PR 的 CI 测试记录中,我无法重现这些故障,也找不到相关的证据。无论如何,我之前的批准意见仍然有效。
   
   Thank you so much for your reply!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5312433708

   +1 if CI passes.
   LGTM
   
   <img width="1358" height="792" alt="image" src="https://github.com/user-attachments/assets/637d1ccd-36ee-4b89-bee7-5e33c422c91b" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5213785394

   Hi! @DanielLeens Thanks for your review!
   There are two changes in latest commit.
   * I have added java doc above the method `absolutelyRequiredOptions`
   * updated pr description


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5242226544

   Welcome aboard, @ClaireLytt! Glad to hear you've joined the Slack workspace. This PR has been a great example of clear, focused connector work end-to-end, and the CI trace-down we did together was a good showcase of solid follow-through too.
   
   Looking forward to seeing more PRs from you — the #contributors channel is a good place to bounce ideas early if you're ever unsure about design direction before writing code. Welcome to the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5229131017

   Hi @ClaireLytt, thanks for flagging this — I dug into the actual CI runs for the current head (a33a9ba) on both attempts before replying, rather than going off the check summary alone.
   
   Good news: I don't see any real CheckpointPlanTest / TaskTest failures for this PR. Specifically:
   - Attempt 1 (finished 2026-08-07 12:48 UTC): in the `unit-test (8, ubuntu-latest)` job log, `org.apache.seatunnel.engine.server.checkpoint.CheckpointPlanTest` ran with `Tests run: 1, Failures: 0, Errors: 0`, and `org.apache.seatunnel.engine.server.dag.TaskTest` ran with `Tests run: 3, Failures: 0, Errors: 0`. Both are clean passes through the `AbstractSeaTunnelServerTest` Hazelcast setup, no errors in `before()` or anywhere else.
   - The only non-passing job in attempt 1 was `unit-test (11, windows-latest)`, which failed — but that's unrelated to Checkpoint/Task tests too.
   - Attempt 2 (the rerun, finished 2026-08-08 08:07 UTC) is fully green on every unit-test job, including `unit-test (11, windows-latest)`, which passed on retry — consistent with that being a flaky/transient failure rather than anything real.
   
   The one job that is still not green in either attempt is `Run / Build website` (the docusaurus docs-site build), which hangs for well over an hour and then gets cancelled — that's what's making the overall `Build` check on the apache side show as failed/cancelled. That's unrelated to the Hazelcast/engine test setup and unrelated to the Iceberg connector code in this PR; it looks like an infra/docs-build flakiness issue on the CI side, not something introduced by your change.
   
   So from my side there's nothing in `CheckpointPlanTest`/`TaskTest`/`AbstractSeaTunnelServerTest` that needs fixing here, and it doesn't block this PR. If you're still seeing those specific test failures locally or in a different run, could you share the run URL or the actual failure stack trace? I'm happy to take another look, but I couldn't reproduce or find evidence of that failure in this PR's CI history. My prior approval stands either way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5225146324

   Hi @DanielLeens 
   The `CheckpointPlanTest` and `TaskTest` failures are in the shared Hazelcast test setup (`AbstractSeaTunnelServerTest.before:70`), not in Iceberg connector code.
   
   Could you please check this problem? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5233647531

   Thanks for your contribution! This is a solid addition to the project, and your attention to detail really shows. Contributors like you are what keep this community moving forward. Feel free to keep the PRs coming — we're always glad to have you here!
   
   Please ignore the following message if you have joined in the Slack~
   ```
   To facilitate focused communication among contributors, we’ve created a brand-new dedicated #contributors channel in official Slack workspace.
   Slack workspace link: https://s.apache.org/seatunnel-slack
   
   This channel is designed for technical discussions, feature design brainstorming, roadmap sync and direct communication with project core Contributors. Everyone who contributes code, docs, test cases or community ideas is warmly invited to join, share thoughts and collaborate together under The Apache Way. Welcome to join 😄
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5237563203

   > https://s.apache.org/seatunnel-slack
   !
   @davidzollo Thank you for inviting me! I have joined slack. I’m looking forward to contributing more pull requests to the SeaTunnel project.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5242220042

   Welcome aboard, @ClaireLytt! Glad to hear you've joined the Slack workspace. This PR has been a great example of clear, focused connector work end-to-end, and the CI trace-down we did together was a good showcase of solid follow-through too.
   
   Looking forward to seeing more PRs from you — the #contributors channel is a good place to bounce ideas early if you're ever unsure about design direction before writing code. Welcome to the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5216096621

   Thanks for the confirmation! Both are already reflected in the head I approved (the javadoc addition doesn't change any behavior, and the description update is informational), so this doesn't need another look from me — still good to merge from my side.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5231609343

   @/private/tmp/claude-501/-Volumes-disk6-tmp-seatunnel-third-nervous-swirles-887e0f/f978b90c-4e26-438b-9ad4-2fbf1f56ae20/scratchpad/pr-batch-20260809/post_bodies/reply_11675.txt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5313614207

   > +1 if CI passes. LGTM
   > 
   > <img alt="image" width="1358" height="792" src="https://private-user-images.githubusercontent.com/15833811/636824442-637d1ccd-36ee-4b89-bee7-5e33c422c91b.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODY5NTUyNTEsIm5iZiI6MTc4Njk1NDk1MSwicGF0aCI6Ii8xNTgzMzgxMS82MzY4MjQ0NDItNjM3ZDFjY2QtMzZlZS00Yjg5LWJlZTctNWUzM2M0MjJjOTFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwODE3VDA4MjIzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyNjdhOGM0Y2ExNGQ2OWQ0NmIwZDUxMjNlMzViM2I3NTI3ZjVmMTRhM2U2N2E3N2YwZTZjMDM2NDdmZGUxNDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.Xb3NloBAs2dYUc0AWux2plozIFF-fFYa8WmNE9LY3KQ">
   
   Hi! CI passes now. Please check it again. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2][Iceberg] Align OptionRule with docs and strengthen factory test [seatunnel]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #11675:
URL: https://github.com/apache/seatunnel/pull/11675#issuecomment-5324126843

   Hi @ClaireLytt, thanks for the well-structured proposal. +1 for the overall direction. I like that it is positioned as an accountable, human-owned first-pass assistant rather than an unsupervised review bot, and the non-goals you listed (no sole approval, no merge/close permissions, named human owner) are exactly the right guardrails.
   
   Regarding the open questions, my take:
   
   1. Let's start with a limited optional pilot (e.g. docs and small first-time-contributor PRs) instead of an official mandatory gate for all PRs.
   2. Yes, AI APPROVE should be informational only and excluded from required review counts.
   3. I'd leave the pilot scope to the initial draft and adjust based on the results.
   
   Please go ahead with the draft review template, pilot criteria and sample reviews you mentioned. Once we see a few concrete sample reviews, it will be much easier for the community to evaluate and decide whether to formalize it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org