You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2013/11/15 00:56:39 UTC
Review Request 15551: SENTRY-64: Circular dependency between
sentry-binding-solr and sentry-core
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15551/
-----------------------------------------------------------
Review request for sentry, Brock Noland and Shreepadma Venugopalan.
Repository: sentry
Description
-------
Breaks up the dependency between sentry-binding-solr and sentry-core. This is done by copying a small amount of utility code from solr into sentry. I think we are okay here because sentry already has a notice that says:
"This product includes software developed at
The Apache Software Foundation (http://www.apache.org/)."
But it would be good if someone who is more informed about this stuff than I am would confirm.
Diffs
-----
pom.xml f5cf265
sentry-binding/sentry-binding-solr/pom.xml a1c8dbf
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java d7b766c
Diff: https://reviews.apache.org/r/15551/diff/
Testing
-------
Ran mvn install
Thanks,
Gregory Chanan
Re: Review Request 15551: SENTRY-64: Circular dependency between
sentry-binding-solr and sentry-core
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15551/#review28927
-----------------------------------------------------------
Ship it!
I' +1 on it, but probably best to check with Patrick Hunt on moving code between projects.
- Shreepadma Venugopalan
On Nov. 14, 2013, 11:56 p.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15551/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 11:56 p.m.)
>
>
> Review request for sentry, Brock Noland and Shreepadma Venugopalan.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Breaks up the dependency between sentry-binding-solr and sentry-core. This is done by copying a small amount of utility code from solr into sentry. I think we are okay here because sentry already has a notice that says:
>
> "This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/)."
>
> But it would be good if someone who is more informed about this stuff than I am would confirm.
>
>
> Diffs
> -----
>
> pom.xml f5cf265
> sentry-binding/sentry-binding-solr/pom.xml a1c8dbf
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java d7b766c
>
> Diff: https://reviews.apache.org/r/15551/diff/
>
>
> Testing
> -------
>
> Ran mvn install
>
>
> Thanks,
>
> Gregory Chanan
>
>