You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/11/18 16:40:16 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #349: Add support for JSON formatting of infoset
Shanedell opened a new pull request, #349:
URL: https://github.com/apache/daffodil-vscode/pull/349
Add support for JSON formatting of infoset
- Create new argument infosetFormat
- Update scala code to support infosetFormat:
- Parse in value from extension.
- Based on parse value decide what InfosetFormatter to use.
- Update extension code to support infosetFormat:
- Add it is a launch arg inside of the launch.json.
- Set default value as "xml".
- Add selection box for infosetFormat on the Launch Wizard.
- Send value over the debugger on launch
- Update infoset view to select file type based on infosetFormat so they look correct.
- Update LaunchArgs interface to include infosetFormat.
- Update unit tests to use value and check that it is set properly
- Update yarn watch to generate src/version.ts before running actual watch command.
Closes #343
NOTE: Currently going to leave as draft as this is an improvement for 1.3.0 so should not be merged till 1.2.0 is fully released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #349: Add support for JSON formatting of infoset
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #349:
URL: https://github.com/apache/daffodil-vscode/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #349: Add support for JSON formatting of infoset
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on code in PR #349:
URL: https://github.com/apache/daffodil-vscode/pull/349#discussion_r1036047664
##########
src/infoset.ts:
##########
@@ -46,8 +46,8 @@ async function openInfosetFilePrompt() {
switch (action) {
case 'Open':
- let xml = await vscode.workspace.openTextDocument(uri)
- await vscode.window.showTextDocument(xml, {
+ let data = await vscode.workspace.openTextDocument(uri)
Review Comment:
Do you really want to call this value "data" ? How about "infoset". Normally we think of data as the input to parse, and infoset as the output from parse, and most of your code follows that naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #349: Add support for JSON formatting of infoset
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #349:
URL: https://github.com/apache/daffodil-vscode/pull/349#issuecomment-1341770066
1.2.0 was released just need to update the page a bit before sending out the announcement so I am going merge this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org