You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by ta...@apache.org on 2004/06/04 20:07:18 UTC

cvs commit: jakarta-jetspeed/src/java/org/apache/jetspeed/util/parser DefaultJetspeedParameterParser.java

taylor      2004/06/04 11:07:18

  Modified:    src/java/org/apache/jetspeed/util/parser
                        DefaultJetspeedParameterParser.java
  Log:
   DefaultJetspeedParameterParser applies the following priorities when determining a encoding information of the form data.
  
   1) the character encoding used in the body of the request.
    2) character-set parameter in media.xreg
    3) content.defaultencoding in JetspeedResources.properties
    4) US-ASCII
  
  I have considered that it is better for Jetspeed to use the encoding used in the requested page. But, for tomcat3 or the compatible one, it seems that ISO-8859-1 is returned in #1. So Jetspeed cannot handle the form data. Therefore #1 should be deleted for fixing this issue.
  
  http://nagoya.apache.org/jira/browse/JS1-487
  
  patch from Shinsuke Sugaya
  
  CVS: ----------------------------------------------------------------------
  CVS: PR:
  CVS:   If this change addresses a PR in the problem report tracking
  CVS:   database, then enter the PR number(s) here.
  CVS: Obtained from:
  CVS:   If this change has been taken from another system, such as NCSA,
  CVS:   then name the system in this line, otherwise delete it.
  CVS: Submitted by:
  CVS:   If this code has been contributed to Apache by someone else; i.e.,
  CVS:   they sent us a patch or a new module, then include their name/email
  CVS:   address here. If this is your work then delete this line.
  CVS: Reviewed by:
  CVS:   If we are doing pre-commit code reviews and someone else has
  CVS:   reviewed your changes, include their name(s) here.
  CVS:   If you have not had it reviewed then delete this line.
  
  Revision  Changes    Path
  1.5       +1 -5      jakarta-jetspeed/src/java/org/apache/jetspeed/util/parser/DefaultJetspeedParameterParser.java
  
  Index: DefaultJetspeedParameterParser.java
  ===================================================================
  RCS file: /home/cvs/jakarta-jetspeed/src/java/org/apache/jetspeed/util/parser/DefaultJetspeedParameterParser.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- DefaultJetspeedParameterParser.java	23 Feb 2004 03:18:08 -0000	1.4
  +++ DefaultJetspeedParameterParser.java	4 Jun 2004 18:07:18 -0000	1.5
  @@ -95,10 +95,6 @@
               }
   
           }
  -        if ( req.getCharacterEncoding() != null )
  -        {
  -            enc = req.getCharacterEncoding();
  -        }
           setCharacterEncoding( enc );
       }
   
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org