You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2014/12/07 13:10:07 UTC
svn commit: r1643668 -
/maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/LicenseReport.java
Author: michaelo
Date: Sun Dec 7 12:10:07 2014
New Revision: 1643668
URL: http://svn.apache.org/r1643668
Log:
* Resolved a TODO with Locale.ROOT
* Added a TODO to localize two license-related strings
Modified:
maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/LicenseReport.java
Modified: maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/LicenseReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/LicenseReport.java?rev=1643668&r1=1643667&r2=1643668&view=diff
==============================================================================
--- maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/LicenseReport.java (original)
+++ maven/plugins/trunk/maven-project-info-reports-plugin/src/main/java/org/apache/maven/report/projectinfo/LicenseReport.java Sun Dec 7 12:10:07 2014
@@ -347,11 +347,10 @@ public class LicenseReport
{
try
{
- // All licenses are supposed in English...
+ // All licenses are supposed to be in English...
String licenseContent = ProjectInfoReportUtils.getContent( licenseUrl, settings, licenseFileEncoding );
// TODO: we should check for a text/html mime type instead, and possibly use a html parser to do this a bit more cleanly/reliably.
- // TODO Use Locale.ROOT as soon as we migrate to Java 6
String licenseContentLC = licenseContent.toLowerCase( Locale.ENGLISH );
int bodyStart = licenseContentLC.indexOf( "<body" );
int bodyEnd = licenseContentLC.indexOf( "</body>" );
@@ -362,6 +361,7 @@ public class LicenseReport
bodyStart = licenseContentLC.indexOf( ">", bodyStart ) + 1;
String body = licenseContent.substring( bodyStart, bodyEnd );
+ // TODO Localize the following the strings
link( licenseUrl.toExternalForm(), "[Original text]" );
paragraph( "Copy of the license follows." );