You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/08 03:35:45 UTC
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2997: [hotfix][ST-Engine] Fix Serializable error
Hisoka-X commented on code in PR #2997:
URL: https://github.com/apache/incubator-seatunnel/pull/2997#discussion_r990581105
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/FileUtils.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.utils;
+
+import org.apache.seatunnel.common.ExceptionUtil;
+
+import lombok.extern.slf4j.Slf4j;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+@Slf4j
+public class FileUtils {
+
+ public static String readFile2Str(Path path) {
Review Comment:
```suggestion
public static String readFileToStr(Path path) {
```
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/FileUtils.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.utils;
+
+import org.apache.seatunnel.common.ExceptionUtil;
+
+import lombok.extern.slf4j.Slf4j;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+@Slf4j
+public class FileUtils {
+
+ public static String readFile2Str(Path path) {
+ try {
+ byte[] bytes = Files.readAllBytes(path);
+ return new String(bytes);
+ } catch (IOException e) {
+ log.error(ExceptionUtil.getMessage(e));
+ throw new RuntimeException(e);
+ }
+ }
+
+ public static void writeStringToFile(String filePath, String str) {
+ PrintStream ps;
+ try {
+ File file = new File(filePath);
+ ps = new PrintStream(new FileOutputStream(file));
Review Comment:
Without close Stream?
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/FileUtils.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.common.utils;
+
+import org.apache.seatunnel.common.ExceptionUtil;
+
+import lombok.extern.slf4j.Slf4j;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+@Slf4j
+public class FileUtils {
+
+ public static String readFile2Str(Path path) {
+ try {
+ byte[] bytes = Files.readAllBytes(path);
+ return new String(bytes);
+ } catch (IOException e) {
+ log.error(ExceptionUtil.getMessage(e));
+ throw new RuntimeException(e);
+ }
+ }
+
+ public static void writeStringToFile(String filePath, String str) {
+ PrintStream ps;
+ try {
+ File file = new File(filePath);
+ ps = new PrintStream(new FileOutputStream(file));
+ ps.println(str);
+ } catch (FileNotFoundException e) {
+ log.error(ExceptionUtil.getMessage(e));
+ throw new RuntimeException(e);
+ }
+ }
+
+ public static void createParentFile(File file) {
+ File parentFile = file.getParentFile();
+ if (null != parentFile && !parentFile.exists()) {
+ parentFile.mkdirs();
+ createParentFile(parentFile);
+ }
+ }
+
+ /**
+ * create a new file, delete the old one if it is exists.
+ * @param filePath filePath
+ */
+ public static void createNewFile(String filePath) {
+ File file = new File(filePath);
+ file.deleteOnExit();
Review Comment:
`deleteOnExit` only work when JVM shutdown, so when user call this method, the old one will not deleted untill JVM shutdown. And also the new file not created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org