[jira] [Resolved] (YUNIKORN-2168) Generate more random data in queue_test.go and template_test.go

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wilfred Spiegelenburg resolved YUNIKORN-2168.
---------------------------------------------
    Fix Version/s: 1.5.0
       Resolution: Fixed

Change committed thx [~brandboat] 

> Generate more random data in queue_test.go and template_test.go
> ---------------------------------------------------------------
>
>                 Key: YUNIKORN-2168
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2168
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler, test - unit
>            Reporter: Kuan-Po Tseng
>            Assignee: Kuan-Po Tseng
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.5.0
>
>
> quoted from [https://github.com/apache/yunikorn-core/pull/696#issuecomment-1820206504]
> {quote}Generate more random data in {{{}getResourceConf(){}}}, something more in the direction of {{rand.Intn(10000)}} instead of the seconds based setup.
> {quote}
> In queue_test.go and template_test.go both use {{getResourceConf()}} that use seconds based random data. And not only getResourceConf(), template_test.go#getProperties() use seconds based random data too. Use rand.Intn instead of using seconds based random data could generate more random data.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org