Change in asterixdb[master]: [ASTERIXDB-2460][FUN] Fix sum() overflow bug

["Hussain Towaileb (Code Review)" <do...@asterixdb.incubator.apache.org>]

Hussain Towaileb has posted comments on this change.

Change subject: [ASTERIXDB-2460][FUN] Fix sum() overflow bug
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3012/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/serializable/std/AbstractSerializableSumAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/serializable/std/AbstractSerializableSumAggregateFunction.java:

Line 246:     // Checks if valid type
Self-comment: This validity check can probably be merged with the switch statement doing the calculation at line 127 to avoid redundant steps.


https://asterix-gerrit.ics.uci.edu/#/c/3012/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractSumAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractSumAggregateFunction.java:

Line 245:     // Checks if valid type
Self-comment: This validity check can probably be merged with the switch statement doing the calculation at line 122 to avoid redundant steps.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3012
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I987417770b3bfbda6af29a27acc8c96dc8a99eb8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes