You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/04/06 17:19:30 UTC
[kudu-CR] [docker] Fix the docker thirdparty build
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15659
Change subject: [docker] Fix the docker thirdparty build
......................................................................
[docker] Fix the docker thirdparty build
After 458e6ce, the docker thirdparty build was failing because
`/build-support/ccache-clang` was not available in the thirdparty image.
I tested this fix by running builds based on ubuntu:xenial, centos:6,
and centos:7 base images.
Change-Id: If25d7b07db4cc20de53b70fe0ab097be6f3756ed
---
M docker/Dockerfile
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/15659/1
--
To view, visit http://gerrit.cloudera.org:8080/15659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If25d7b07db4cc20de53b70fe0ab097be6f3756ed
Gerrit-Change-Number: 15659
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Fix the docker thirdparty build
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15659 )
Change subject: [docker] Fix the docker thirdparty build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If25d7b07db4cc20de53b70fe0ab097be6f3756ed
Gerrit-Change-Number: 15659
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Apr 2020 19:35:50 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Fix the docker thirdparty build
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15659 )
Change subject: [docker] Fix the docker thirdparty build
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15659/1/docker/Dockerfile
File docker/Dockerfile:
http://gerrit.cloudera.org:8080/#/c/15659/1/docker/Dockerfile@108
PS1, Line 108: COPY ./build-support/ccache-clang build-support/ccache-clang
: COPY ./build-support/ccache-devtoolset-3 build-support/ccache-devtoolset-3
Just curious, would it also have worked to merge this with L105..107?
--
To view, visit http://gerrit.cloudera.org:8080/15659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If25d7b07db4cc20de53b70fe0ab097be6f3756ed
Gerrit-Change-Number: 15659
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Apr 2020 19:32:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Fix the docker thirdparty build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15659 )
Change subject: [docker] Fix the docker thirdparty build
......................................................................
[docker] Fix the docker thirdparty build
After 458e6ce, the docker thirdparty build was failing because
`/build-support/ccache-clang` was not available in the thirdparty image.
I tested this fix by running builds based on ubuntu:xenial, centos:6,
and centos:7 base images.
Change-Id: If25d7b07db4cc20de53b70fe0ab097be6f3756ed
Reviewed-on: http://gerrit.cloudera.org:8080/15659
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docker/Dockerfile
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If25d7b07db4cc20de53b70fe0ab097be6f3756ed
Gerrit-Change-Number: 15659
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)