You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org> on 2010/08/20 10:46:15 UTC
[jira] Created: (QPID-2811) Rationalise 0-10 Transport Interface
Rationalise 0-10 Transport Interface
------------------------------------
Key: QPID-2811
URL: https://issues.apache.org/jira/browse/QPID-2811
Project: Qpid
Issue Type: Improvement
Components: Java Broker, Java Client, Java Common
Affects Versions: 0.7
Reporter: Andrew Kennedy
Fix For: 0.7
Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Issue Comment Edited: (QPID-2811) Rationalise 0-10 Transport
Interface
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900726#action_12900726 ]
Andrew Kennedy edited comment on QPID-2811 at 8/20/10 11:13 AM:
----------------------------------------------------------------
This is pretty much what I'm doing, actually, although I would like to remove the reflection and use OSGi (on the broker) eventually. I am working on a more detailed piece of documentation, which I will upload asap. The IoTransport class doesn't seem useful to me, but I will be keeping IoNetworkTransport, with only a few changes.
was (Author: andrew.kennedy):
This is pretty much what I'm doing, actually, although I would like to remove the reflection and use OSGi eventually. I am working on a more detailed piece of documentation, which I will upload asap. The IoTransport class doesn't seem useful to me, but I will be keeping IoNetworkTransport, with only a few changes.
> Rationalise 0-10 Transport Interface
> ------------------------------------
>
> Key: QPID-2811
> URL: https://issues.apache.org/jira/browse/QPID-2811
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2811) Rationalise 0-10 Transport Interface
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900726#action_12900726 ]
Andrew Kennedy commented on QPID-2811:
--------------------------------------
This is pretty much what I'm doing, actually, although I would like to remove the reflection and use OSGi eventually. I am working on a more detailed piece of documentation, which I will upload asap. The IoTransport class doesn't seem useful to me, but I will be keeping IoNetworkTransport, with only a few changes.
> Rationalise 0-10 Transport Interface
> ------------------------------------
>
> Key: QPID-2811
> URL: https://issues.apache.org/jira/browse/QPID-2811
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2811) Rationalise 0-10 Transport Interface
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy reassigned QPID-2811:
------------------------------------
Assignee: Andrew Kennedy
> Rationalise 0-10 Transport Interface
> ------------------------------------
>
> Key: QPID-2811
> URL: https://issues.apache.org/jira/browse/QPID-2811
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Assignee: Andrew Kennedy
> Fix For: 0.7
>
>
> Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2811) Rationalise 0-10 Transport Interface
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900716#action_12900716 ]
Rajith Attapattu commented on QPID-2811:
----------------------------------------
Andrew,
Could you please be more specific about your plans ?
I have made some minor improvements to support (QPID-2447, QPID-2444, QPID-2445, QPID-2446, QPID-2447).
In summary those changes are as follows,
1. Allow the ability to load any transport that implements the NetworkTransport interface through reflection.
This simply allows the transports to be moved outside of the client and common modules which is one of my goals.
Look at Transport.java, NetworkTransport.java and IoNetworkTransport.java
2. A helper class called SecurityLayer which wraps our senders and receivers with SSL and SASL if they have been configured by the user.
3. TransportBuilder class to build the sender and receiver pipelines.
I think what I have done is good enough as a starting point to move out the transport code into a separate module.
I would be tempted to keep the IoTransport within the common module as it does not contain any external dependencies.
And then move the MINA transport to a separate module and also add any new transports like Netty ..etc into that module.
> Rationalise 0-10 Transport Interface
> ------------------------------------
>
> Key: QPID-2811
> URL: https://issues.apache.org/jira/browse/QPID-2811
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2811) Rationalise 0-10 Transport Interface
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900730#action_12900730 ]
Rajith Attapattu commented on QPID-2811:
----------------------------------------
-1 on removing the ability to load a transport via reflection as it allows a simple and effective way of loading a transport without the need for things like OSGi.
As mentioned before I am not opposed to you making the transports loaded via OSGi as long as no deps are introduced in the client and common modules.
I think it's possible all though it may need some careful thinking. If needed I am quite happy to work with you to achieve it.
> Rationalise 0-10 Transport Interface
> ------------------------------------
>
> Key: QPID-2811
> URL: https://issues.apache.org/jira/browse/QPID-2811
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2811) Rationalise 0-10 Transport Interface
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900733#action_12900733 ]
Rajith Attapattu commented on QPID-2811:
----------------------------------------
The IoTransport class is not used in the new mechanism. I did not remove it as it seems the 0-8/0-9 client was dependent on it.
So I'd left it as it is.
I also see that you have edited your comment. I misunderstood the previous comment as you suggesting to remove the reflection based method for the client as well.
My -1 for OSGi only applies to the client and that too only if deps are introduced into client and common modules.
Keep us posted, happy to help when ever I can.
> Rationalise 0-10 Transport Interface
> ------------------------------------
>
> Key: QPID-2811
> URL: https://issues.apache.org/jira/browse/QPID-2811
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Client, Java Common
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Create or modify current transport mechanism classes and interfaces to make them more generic and allow for other mechanisms and protocols to be added in a modular way.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org