Re: [PR] [T1] Allow fixed length encoding for min/max and deprecate encoding_stats [parquet-format]

["emkornfield (via GitHub)" <gi...@apache.org>]

emkornfield commented on code in PR #252:
URL: https://github.com/apache/parquet-format/pull/252#discussion_r1622698456


##########
src/main/thrift/parquet.thrift:
##########
@@ -243,42 +243,39 @@ struct SizeStatistics {
  */
 struct Statistics {
    /**
-    * DEPRECATED: min and max value of the column. Use min_value and max_value.
+    * max/min: deprecated, used to encoded signed orderable values, ignoring
+    *   the columns ColumnOrder
+    * max_value/min_value: PLAIN encoded values, sans length prefix if varlen
+    * max8/min8: up to 8-bytes:
+    *   FLOAT, DOUBLE: bitcasted to INT32 and INT64, respectively

Review Comment:
   I think we might want to be more specific here about values less then 8 bytes are translated into 8 bytes.  In practice it doesn't make a difference for readers but it would be good to limit ambiguity.  I assume we do a normal cast from 1/4 integer byte values to 8 bytes values rather then just embedding them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org