[jira] [Commented] (HADOOP-17680) Allow ProtobufRpcEngine to be extensible

["Hector Sandoval Chaverri (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338645#comment-17338645 ] 

Hector Sandoval Chaverri commented on HADOOP-17680:
---------------------------------------------------

Thanks for taking a look [~shv]. I've made the following changes:
 # Moved this Jira to the Hadoop Common project.
 # Reverted the changes to make members protected and only added the getters that are needed.

There are still warnings about pre-existing issues, regarding the number of parameters in the Invoker constructor.

 

> Allow ProtobufRpcEngine to be extensible
> ----------------------------------------
>
>                 Key: HADOOP-17680
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17680
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: Hector Sandoval Chaverri
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The ProtobufRpcEngine class doesn't allow for new RpcEngine implementations to extend some of its inner classes (e.g. Invoker and Server.ProtoBufRpcInvoker). Also, some of its methods are long enough such that overriding them would result in a lot of code duplication (e.g. Invoker#invoke and Server.ProtoBufRpcInvoker#call).
> When implementing a new RpcEngine, it would be helpful to reuse most of the code already in ProtobufRpcEngine. This would allow new fields to be added to the RPC header or message with minimal code changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org