You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (Commented) (JIRA)" <ji...@apache.org> on 2012/01/18 22:44:39 UTC
[jira] [Commented] (HTTPCLIENT-1159) HttpClientUtils - Helper
methods to release resources of HttpClient / HttpResponse after use
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188722#comment-13188722 ]
Sebb commented on HTTPCLIENT-1159:
----------------------------------
Catching Exception is not ideal; it would be better to catch the expected exceptions and allow any others to propagate.
Also there are now 3 versions of the patch attached; the obsolete ones could perhaps be deleted?
> HttpClientUtils - Helper methods to release resources of HttpClient / HttpResponse after use
> ----------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1159
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1159
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.1.2
> Reporter: Karthik K
> Fix For: 4.2 Alpha2
>
> Attachments: HTTPCLIENT-1159.patch, HTTPCLIENT-1159.patch, HTTPCLIENT-1159.patch
>
>
> Found myself writing this boiler plate code in various httpclient related projects , to release resources , and wanted to provide a simpler way to release resources similar to IOUtils.closeQuietly as opposed to maintaining the same in my code.
> New class:
> o.a.http.client.utils.HttpClientUtils added:
> <pre>
> public static void closeQuietly(final HttpResponse response);
> public static void closeQuietly(final HttpClient httpClient);
> </pre>
> with 2 methods ( as above ) in the same, to help release resources:
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org