You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2026/09/26 07:10:18 UTC
[PR] test: isolate TM bootstrap options from remote connection setup [incubator-seata]
slievrly opened a new pull request, #8261:
URL: https://github.com/apache/incubator-seata/pull/8261
- [x] I have read the contributing guidelines.
- [x] I have registered the PR changes.
### Ⅰ. Describe what this PR did
Give the bootstrap-option test a fresh client with a mocked connection manager. Verify initReconnect is requested while retaining real Netty bootstrap/channel-option assertions, close the inspected channel, and always destroy the client. Remove the unrelated RM fail-fast system-property mutation.
### Ⅱ. Does this pull request fix one issue?
Fixes #8260.
### Ⅲ. Test cases
All 5 TmNettyClientTest cases pass. The explicit fail-fast connection failure test remains unchanged and continues to assert FrameworkException.
### Ⅳ. Describe how to verify it
Java 17: `mvn -pl core -am test -Dtest=TmNettyClientTest -Dsurefire.failIfNoSpecifiedTests=false`; 5 tests passed.
### Ⅴ. Special notes for reviews
Source: [Java 17 CI job](https://github.com/apache/incubator-seata/actions/runs/35840434140/job/107113931949).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: isolate TM bootstrap options from remote connection setup [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8261:
URL: https://github.com/apache/incubator-seata/pull/8261#issuecomment-5844302256
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8261?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.18%. Comparing base ([`96e84e5`](https://app.codecov.io/gh/apache/incubator-seata/commit/96e84e52f1013c484ef524afefdc81a2fb981d18?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f7f07ba`](https://app.codecov.io/gh/apache/incubator-seata/commit/f7f07bad868fb02bb2e83b735e542fa0d6f43c5a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8261 +/- ##
============================================
- Coverage 73.33% 73.18% -0.15%
Complexity 1146 1146
============================================
Files 1153 1153
Lines 42348 42348
Branches 5061 5061
============================================
- Hits 31056 30994 -62
- Misses 8811 8873 +62
Partials 2481 2481
```
[see 22 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8261/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: isolate TM bootstrap options from remote connection setup [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #8261:
URL: https://github.com/apache/incubator-seata/pull/8261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org