[GitHub] [iotdb] Alima777 commented on a change in pull request #3926: Inefficient Usage of JCF

[GitBox <gi...@apache.org>]

Alima777 commented on a change in pull request #3926:
URL: https://github.com/apache/iotdb/pull/3926#discussion_r703982984



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/chunk/VectorChunkReader.java
##########
@@ -59,7 +59,7 @@
 
   protected Filter filter;
 
-  private final List<IPageReader> pageReaderList = new LinkedList<>();
+  private final List<IPageReader> pageReaderList = new ArrayList<>();

Review comment:
       In vectorChunkReader Line 268, `return pageReaderList.remove(0).getAllSatisfiedPageData();`

##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/chunk/ChunkReader.java
##########
@@ -55,7 +55,7 @@
 
   protected Filter filter;
 
-  private List<IPageReader> pageReaderList = new LinkedList<>();
+  private List<IPageReader> pageReaderList = new ArrayList<>();

Review comment:
       In chunkReader Line 118, `return pageReaderList.remove(0).getAllSatisfiedPageData();`

##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/FilePartitionedSnapshotLogManager.java
##########
@@ -130,11 +133,11 @@ private void collectTsFilesAndFillTimeseriesSchemas(List<Integer> requiredSlots)
 
     // 2.register the measurement
     boolean slotExistsInPartition;
-    List<Integer> slots = null;
+    HashSet<Integer> slots = null;

Review comment:
       It's ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org