[GitHub] [cassandra] maedhroz commented on a diff in pull request #2257: CASSANDRA-18375: Fix response verb for ACCORD_INFORM_OF_TXNID_REQ

["maedhroz (via GitHub)" <gi...@apache.org>]

maedhroz commented on code in PR #2257:
URL: https://github.com/apache/cassandra/pull/2257#discussion_r1154934056


##########
src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java:
##########
@@ -179,7 +179,8 @@ private void finish(R result)
     private void fail(Throwable throwable)
     {
         Invariants.nonNull(throwable);
-        Invariants.checkArgument(state != State.FINISHED && state != State.FAILED, "Unexpected state %s", state);
+        if (!(state != State.FINISHED && state != State.FAILED))

Review Comment:
   ```suggestion
           if (state == State.FINISHED || state == State.FAILED)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org