You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2005/09/19 13:32:55 UTC

[jira] Erstellt: (JCR-218) [JCR-RMI] Have ClientItem.isSame throw RepositoryException

[JCR-RMI] Have ClientItem.isSame throw RepositoryException
----------------------------------------------------------

         Key: JCR-218
         URL: http://issues.apache.org/jira/browse/JCR-218
     Project: Jackrabbit
        Type: Improvement
 Environment: Jackrabbit SVN Rev. 290115
    Reporter: Felix Meschberger
 Assigned to: Jukka Zitting 


Currently the ClientItem.isSame(Item) method wraps a RepositoryException thrown from the path comparison into a RuntimeException and omits an exception declaration on the method. This contrasts with the API specification which allows for a RepositoryExcption to be thrown.

I suggest, to modify ClientItem.isSame(Item) such that the RepositoryException is declared and thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (JCR-218) [JCR-RMI] Have ClientItem.isSame throw RepositoryException

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-218?page=all ]
     
Jukka Zitting closed JCR-218:
-----------------------------


> [JCR-RMI] Have ClientItem.isSame throw RepositoryException
> ----------------------------------------------------------
>
>          Key: JCR-218
>          URL: http://issues.apache.org/jira/browse/JCR-218
>      Project: Jackrabbit
>         Type: Improvement
>  Environment: Jackrabbit SVN Rev. 290115
>     Reporter: Felix Meschberger
>     Assignee: Jukka Zitting
>      Fix For: 1.0
>  Attachments: rmi_fme_20050919.diff
>
> Currently the ClientItem.isSame(Item) method wraps a RepositoryException thrown from the path comparison into a RuntimeException and omits an exception declaration on the method. This contrasts with the API specification which allows for a RepositoryExcption to be thrown.
> I suggest, to modify ClientItem.isSame(Item) such that the RepositoryException is declared and thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (JCR-218) [JCR-RMI] Have ClientItem.isSame throw RepositoryException

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-218?page=all ]
     
Jukka Zitting resolved JCR-218:
-------------------------------

    Fix Version: 1.0
     Resolution: Fixed

Patch applied in revision 290433. Thanks for the suggestion and patch!

> [JCR-RMI] Have ClientItem.isSame throw RepositoryException
> ----------------------------------------------------------
>
>          Key: JCR-218
>          URL: http://issues.apache.org/jira/browse/JCR-218
>      Project: Jackrabbit
>         Type: Improvement
>  Environment: Jackrabbit SVN Rev. 290115
>     Reporter: Felix Meschberger
>     Assignee: Jukka Zitting
>      Fix For: 1.0
>  Attachments: rmi_fme_20050919.diff
>
> Currently the ClientItem.isSame(Item) method wraps a RepositoryException thrown from the path comparison into a RuntimeException and omits an exception declaration on the method. This contrasts with the API specification which allows for a RepositoryExcption to be thrown.
> I suggest, to modify ClientItem.isSame(Item) such that the RepositoryException is declared and thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Aktualisiert: (JCR-218) [JCR-RMI] Have ClientItem.isSame throw RepositoryException

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-218?page=all ]

Felix Meschberger updated JCR-218:
----------------------------------

    Attachment: rmi_fme_20050919.diff

Proposed patch.

This patch also includes an modification to the "type" test: we just compare the isNode() result of both items to decide whether they are both items or properties.

> [JCR-RMI] Have ClientItem.isSame throw RepositoryException
> ----------------------------------------------------------
>
>          Key: JCR-218
>          URL: http://issues.apache.org/jira/browse/JCR-218
>      Project: Jackrabbit
>         Type: Improvement
>  Environment: Jackrabbit SVN Rev. 290115
>     Reporter: Felix Meschberger
>     Assignee: Jukka Zitting
>  Attachments: rmi_fme_20050919.diff
>
> Currently the ClientItem.isSame(Item) method wraps a RepositoryException thrown from the path comparison into a RuntimeException and omits an exception declaration on the method. This contrasts with the API specification which allows for a RepositoryExcption to be thrown.
> I suggest, to modify ClientItem.isSame(Item) such that the RepositoryException is declared and thrown.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira