You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2026/07/16 17:52:43 UTC

[PR] [SPARK-58176][DOCS] Add SQL reference documentation for ASOF JOIN [spark]

srielau opened a new pull request, #57312:
URL: https://github.com/apache/spark/pull/57312

   ## What changes were proposed in this pull request?
   
   Add Spark SQL Language Reference documentation for `ASOF JOIN`, based on the SQL reference spec used to implement the feature.
   
   - New page: `docs/sql-ref-syntax-qry-select-asof-join.md` (syntax, parameters, semantics, examples)
   - Cross-links from `JOIN`, `SELECT`, and SQL Syntax index pages
   - Migration guide note for Spark 4.3 (`spark.sql.join.asofJoin.enabled`, default `false`)
   
   This PR is stacked on the ASOF JOIN implementation subtasks (parser, analysis, execution, integration tests, FVT). It should merge after those land, or together if the stack is reviewed as a whole.
   
   ## Why are the changes needed?
   
   SPARK-58176 tracks user-facing documentation for the new `ASOF JOIN` SQL syntax introduced by the ASOF JOIN feature stack.
   
   ## Does this PR introduce _any_ user-facing change?
   
   Yes — documentation only.
   
   ## How was this patch tested?
   
   Docs-only change. Examples follow the SQL reference spec and match the FVT golden-file scenarios.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Yes, with human review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58176][DOCS] Add SQL reference documentation for ASOF JOIN [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #57312:
URL: https://github.com/apache/spark/pull/57312#issuecomment-5045445713

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/b6887e8e766d646c27f88b1c0881bd223c8abf80
   - merged into branch-4.x https://github.com/apache/spark/commit/b0077f0f1d966a5e138d2b977d22b4bbbaba1d9e
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58176][DOCS] Add SQL reference documentation for ASOF JOIN [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #57312: [SPARK-58176][DOCS] Add SQL reference documentation for ASOF JOIN
URL: https://github.com/apache/spark/pull/57312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58176][DOCS] Add SQL reference documentation for ASOF JOIN [spark]

Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on PR #57312:
URL: https://github.com/apache/spark/pull/57312#issuecomment-5022907332

   > @srielau how does this PR relate to #57306?
   The QA is icing on the cake. Teh doc teh cherry on top :-)
   This is a stacked PR. That's why you see QA commit as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58176][DOCS] Add SQL reference documentation for ASOF JOIN [spark]

Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on PR #57312:
URL: https://github.com/apache/spark/pull/57312#issuecomment-5041976410

   Rebased onto current `master` now that #57306 merged — this PR is docs-only again (single commit, 5 files). The earlier FVT commits were dropped from the branch since they are already on `master` as `3efa949`.
   
   ---
   <!-- GITHUB_MCP_FOOTER: This attribution is automatically appended by GitHub MCP. -->
   _This comment was generated with [GitHub MCP](http://go/mcps)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org