[jira] [Commented] (PHOENIX-5478) IndexTool mapper task should not timeout

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957342#comment-16957342 ] 

Hadoop QA commented on PHOENIX-5478:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12983766/PHOENIX-5478.master.001.patch
  against master branch at commit 14fd888a3487350b081b31f63d3e1c37b3d6f968.
  ATTACHMENT ID: 12983766

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        IndexRebuildRegionScanner (final RegionScanner innerScanner, final Region region, final Scan scan,
+            maxBatchSize = config.getInt(MUTATE_BATCH_SIZE_ATTRIB, QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE);
+                                if (KeyValue.Type.codeToType(cell.getTypeByte()) == KeyValue.Type.Put) {
+                                        put.setAttribute(useProto ? PhoenixIndexCodec.INDEX_PROTO_MD : PhoenixIndexCodec.INDEX_MD, indexMetaData);
+                                                BaseScannerRegionObserver.REPLAY_INDEX_REBUILD_WRITES);
+                                        put.setAttribute(BaseScannerRegionObserver.CLIENT_VERSION, clientVersionBytes);
+                                        // Since we're replaying existing mutations, it makes no sense to write them to the wal
+                                        del.setAttribute(useProto ? PhoenixIndexCodec.INDEX_PROTO_MD : PhoenixIndexCodec.INDEX_MD, indexMetaData);
+                                                BaseScannerRegionObserver.REPLAY_INDEX_REBUILD_WRITES);
+                                        del.setAttribute(BaseScannerRegionObserver.CLIENT_VERSION, clientVersionBytes);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3058//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3058//console

This message is automatically generated.

> IndexTool mapper task should not timeout 
> -----------------------------------------
>
>                 Key: PHOENIX-5478
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5478
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.15.0
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>         Attachments: PHOENIX-5478.master.001.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In the old design, the IndexTool MR job mapper first scanned the data table rows one by one using a Phoenix client code, then constructed the index rows and finally sent these row mutations to region servers to update the rows on the index table regions. In the new design, this entire process is done on the server side (within a coprocessor). So, the mapper just issues one RPC call to instruct the coprocessor to build the entire table region. This RPC call can timeout if the table region is large. The temporary solution that is currently used is to set very large timeout values. We should break up single table region rebuild into smaller operations and eliminate setting large timeout values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)