You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/09 04:24:43 UTC

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4967: Refactor pinot-batch-ingestion job specs to pinot-spi

codecov-io edited a comment on issue #4967: Refactor pinot-batch-ingestion job specs to pinot-spi
URL: https://github.com/apache/incubator-pinot/pull/4967#issuecomment-572359843
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=h1) Report
   > Merging [#4967](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/97c7118516ef5ded92b742f8cd89166b3c198b49?src=pr&el=desc) will **increase** coverage by `21.33%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4967/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #4967       +/-   ##
   ============================================
   + Coverage     36.06%   57.4%   +21.33%     
   - Complexity        0      12       +12     
   ============================================
     Files          1174    1171        -3     
     Lines         62349   62027      -322     
     Branches       9175    9120       -55     
   ============================================
   + Hits          22487   35605    +13118     
   + Misses        37851   23764    -14087     
   - Partials       2011    2658      +647
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...he/pinot/spi/batch/ingestion/spec/PushJobSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvUHVzaEpvYlNwZWMuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...not/spi/batch/ingestion/spec/RecordReaderSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvUmVjb3JkUmVhZGVyU3BlYy5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...ache/pinot/spi/batch/ingestion/spec/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...atch/ingestion/spec/SegmentGenerationTaskSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvU2VnbWVudEdlbmVyYXRpb25UYXNrU3BlYy5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...he/pinot/spi/batch/ingestion/spec/PinotFSSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvUGlub3RGU1NwZWMuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...not/spi/batch/ingestion/spec/PinotClusterSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvUGlub3RDbHVzdGVyU3BlYy5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...batch/ingestion/spec/SegmentNameGeneratorSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvU2VnbWVudE5hbWVHZW5lcmF0b3JTcGVjLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...ache/pinot/spi/batch/ingestion/spec/TableSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvVGFibGVTcGVjLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...inot/spi/batch/ingestion/IngestionJobLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL0luZ2VzdGlvbkpvYkxhdW5jaGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...i/batch/ingestion/spec/ExecutionFrameworkSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvYmF0Y2gvaW5nZXN0aW9uL3NwZWMvRXhlY3V0aW9uRnJhbWV3b3JrU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | ... and [599 more](https://codecov.io/gh/apache/incubator-pinot/pull/4967/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=footer). Last update [97c7118...6739e00](https://codecov.io/gh/apache/incubator-pinot/pull/4967?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org