[GitHub] [iceberg] rdblue commented on a change in pull request #1141: Document field-id requirements for partition specs

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1141:
URL: https://github.com/apache/iceberg/pull/1141#discussion_r449916726



##########
File path: site/docs/spec.md
##########
@@ -646,6 +646,18 @@ Each partition field in the fields list is stored as an object. See the table fo
 
 In some cases partition specs are stored using only the field list instead of the object format that includes the spec ID, like the deprecated `partition-spec` field in table metadata. The object format should be used unless otherwise noted in this spec.
 
+#### Partition Field ID handling
+
+A partition field id is an integer (starting at 1000) used to identify a partition field.

Review comment:
       The requirement isn't to start at 1000, it is that the IDs should not conflict with the IDs required for the other fields in data files. I think starting at 1000 is a good recommendation to avoid that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org