You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/11 16:49:32 UTC

[GitHub] [beam] yixiaoshen opened a new pull request, #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

yixiaoshen opened a new pull request, #23578:
URL: https://github.com/apache/beam/pull/23578

   Dataflow runner takes much longer to run any IT test, the artificial timeout added in FirestoreV1IT makes the test flaky, other IT tests don't set this timeout and many of them can run >10 minutes on Dataflow runner.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj merged pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
chamikaramj merged PR #23578:
URL: https://github.com/apache/beam/pull/23578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1277890745

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1278037519

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] yixiaoshen commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
yixiaoshen commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1275205493

   R: @ahmedabu98


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] yixiaoshen commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
yixiaoshen commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1274994643

   Run PostCommit_Java_DataflowV2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1278129728

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] yixiaoshen commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
yixiaoshen commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1274994134

   Run PostCommit_Java_Dataflow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1278039895

   Firestore tests passed for both Dataflow v1 and v1 in the above runs (failures are unrelated) so we can merge when Java PreCommit passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] ahmedabu98 commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1275227311

   LGTM
   R: @robertwb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #23578: Remove artificial timeout in FirestoreV1IT, Dataflow runner is very slow

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23578:
URL: https://github.com/apache/beam/pull/23578#issuecomment-1275207053

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org