Re: [PR] Add async PerformAsync and FlushAsync methods with CancellationToken support [lucenenet]

["paulirwin (via GitHub)" <gi...@apache.org>]

paulirwin commented on code in PR #1170:
URL: https://github.com/apache/lucenenet/pull/1170#discussion_r2313937552


##########
src/Lucene.Net.Replicator/Support/Http/Abstractions/IReplicationResponse.cs:
##########
@@ -42,5 +44,12 @@ public interface IReplicationResponse
         /// Flushes the reponse to the underlying response stream.
         /// </summary>
         void Flush();
+
+        /// <summary>
+        /// Flushes the response to the underlying response stream asynchronously.
+        /// </summary>
+        /// <param name="cancellationToken">Optional cancellation token.</param>
+        /// <returns>A task representing the asynchronous operation.</returns>
+        Task FlushAsync(CancellationToken cancellationToken = default);

Review Comment:
   I agree with separate interfaces as well. Let's get it done. +1 for `IAsyncReplicationResponse` and `IAsyncReplicationService`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org