You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:26:12 UTC
[GitHub] [calcite] xy2953396112 opened a new pull request #1734:
[CALCITE-3262] Refine doc of SubstitutionVisitor (dz)
xy2953396112 opened a new pull request #1734: [CALCITE-3262] Refine doc of SubstitutionVisitor (dz)
URL: https://github.com/apache/calcite/pull/1734
Before this pr, JIRA: https://issues.apache.org/jira/browse/CALCITE-3262 refine the doc.
this pr refine doc for `Calc`、`Intersect`、`Sort` relational operators in SubstitutionVisitor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] xy2953396112 closed pull request #1734: [CALCITE-3262]
Refine doc of SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
xy2953396112 closed pull request #1734: [CALCITE-3262] Refine doc of SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] xy2953396112 commented on a change in pull request #1734:
[CALCITE-3262] Refine doc of SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #1734: [CALCITE-3262] Refine doc of SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1734#discussion_r364055999
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -115,8 +115,11 @@
* {@link org.apache.calcite.rel.core.TableScan},
* {@link org.apache.calcite.rel.core.Filter},
* {@link org.apache.calcite.rel.core.Project},
+ * {@link org.apache.calcite.rel.core.Calc},
* {@link org.apache.calcite.rel.core.Join},
* {@link org.apache.calcite.rel.core.Union},
+ * {@link org.apache.calcite.rel.core.Intersect},
+ * {@link org.apache.calcite.rel.core.Sort},
Review comment:
Thanks for you review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1734:
[CALCITE-3262] Refine doc of SubstitutionVisitor
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1734: [CALCITE-3262] Refine doc of SubstitutionVisitor
URL: https://github.com/apache/calcite/pull/1734#discussion_r364054446
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -115,8 +115,11 @@
* {@link org.apache.calcite.rel.core.TableScan},
* {@link org.apache.calcite.rel.core.Filter},
* {@link org.apache.calcite.rel.core.Project},
+ * {@link org.apache.calcite.rel.core.Calc},
* {@link org.apache.calcite.rel.core.Join},
* {@link org.apache.calcite.rel.core.Union},
+ * {@link org.apache.calcite.rel.core.Intersect},
+ * {@link org.apache.calcite.rel.core.Sort},
Review comment:
Doc like enumerating the classes are hard to maintain, people should always remember to update the references, let's avoid to make such kind of doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services