You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/05 02:03:17 UTC

[GitHub] [flink] dianfu commented on a change in pull request #12476: [FLINK-17902][python] Support the new interfaces about temporary functions in PyFlink

dianfu commented on a change in pull request #12476:
URL: https://github.com/apache/flink/pull/12476#discussion_r435641864



##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -147,30 +147,185 @@ def get_catalog(self, catalog_name):
         else:
             return None
 
-    def load_module(self, module_name: str, module: Module):

Review comment:
       What's the reason of this change? We are to support type hint in 1.12 and so it will be good if the newly introduced interfaces uses type hint.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org