You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/05/11 20:21:44 UTC
Re: Review Request 58486: Update the allocator on a per offer
operation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
-----------------------------------------------------------
(Updated May 11, 2017, 8:21 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Summary (updated)
-----------------
Update the allocator on a per offer operation.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description (updated)
-------
The allocator is updated for each offer operation in the order specified
in the `ACCEPT` call. Once the allocator is updated successfully, we
handle subsequent operations as follows:
1) Launch or Launch Group: We launch the tasks or task group on the
agent.
2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
the `CheckPointResourcesMessage` to the agent.
If allocation for any of the operations fail, those resources are not
recovered from the allocator.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/58486/diff/4/
Changes: https://reviews.apache.org/r/58486/diff/3-4/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review175227
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59194, 59195, 58486]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 17, 2017, 2 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 2 a.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
>
> 1) Launch or Launch Group: We launch the tasks or task group on the
> agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
> the `CheckPointResourcesMessage` to the agent.
>
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
>
>
> Diffs
> -----
>
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/58486/diff/7/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review175297
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59194, 59195, 58486]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 17, 2017, 4:50 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 4:50 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
>
> 1) Launch or Launch Group: We launch the tasks or task group on the
> agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
> the `CheckPointResourcesMessage` to the agent.
>
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
>
>
> Diffs
> -----
>
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/58486/diff/8/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
-----------------------------------------------------------
(Updated May 17, 2017, 4:50 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Do not recalculate resources to be recovered if there is no error in `updateAllocation()`.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
The allocator is updated for each offer operation in the order specified
in the `ACCEPT` call. Once the allocator is updated successfully, we
handle subsequent operations as follows:
1) Launch or Launch Group: We launch the tasks or task group on the
agent.
2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
the `CheckPointResourcesMessage` to the agent.
If allocation for any of the operations fail, those resources are not
recovered from the allocator.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/58486/diff/8/
Changes: https://reviews.apache.org/r/58486/diff/7-8/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
-----------------------------------------------------------
(Updated May 17, 2017, 2 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Validate that the valid operations can be processed in `Master::__accept()`.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
The allocator is updated for each offer operation in the order specified
in the `ACCEPT` call. Once the allocator is updated successfully, we
handle subsequent operations as follows:
1) Launch or Launch Group: We launch the tasks or task group on the
agent.
2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
the `CheckPointResourcesMessage` to the agent.
If allocation for any of the operations fail, those resources are not
recovered from the allocator.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/58486/diff/7/
Changes: https://reviews.apache.org/r/58486/diff/6-7/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review175055
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59194, 59195, 58486]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 15, 2017, 6:01 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 6:01 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
>
> 1) Launch or Launch Group: We launch the tasks or task group on the
> agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
> the `CheckPointResourcesMessage` to the agent.
>
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
>
>
> Diffs
> -----
>
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/58486/diff/6/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
-----------------------------------------------------------
(Updated May 15, 2017, 6:01 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
The allocator is updated for each offer operation in the order specified
in the `ACCEPT` call. Once the allocator is updated successfully, we
handle subsequent operations as follows:
1) Launch or Launch Group: We launch the tasks or task group on the
agent.
2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
the `CheckPointResourcesMessage` to the agent.
If allocation for any of the operations fail, those resources are not
recovered from the allocator.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/58486/diff/6/
Changes: https://reviews.apache.org/r/58486/diff/5-6/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review174892
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59194, 59195, 58486]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 13, 2017, 4:51 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> -----------------------------------------------------------
>
> (Updated May 13, 2017, 4:51 a.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
>
> 1) Launch or Launch Group: We launch the tasks or task group on the
> agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
> the `CheckPointResourcesMessage` to the agent.
>
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
>
>
> Diffs
> -----
>
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/58486/diff/5/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/
-----------------------------------------------------------
(Updated May 13, 2017, 4:51 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7308
https://issues.apache.org/jira/browse/MESOS-7308
Repository: mesos
Description
-------
The allocator is updated for each offer operation in the order specified
in the `ACCEPT` call. Once the allocator is updated successfully, we
handle subsequent operations as follows:
1) Launch or Launch Group: We launch the tasks or task group on the
agent.
2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
the `CheckPointResourcesMessage` to the agent.
If allocation for any of the operations fail, those resources are not
recovered from the allocator.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/58486/diff/5/
Changes: https://reviews.apache.org/r/58486/diff/4-5/
Testing
-------
Tests passed.
Thanks,
Anindya Sinha
Re: Review Request 58486: Update the allocator on a per offer
operation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58486/#review174780
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59194, 59195, 58486]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 11, 2017, 8:21 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58486/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 8:21 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-7308
> https://issues.apache.org/jira/browse/MESOS-7308
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator is updated for each offer operation in the order specified
> in the `ACCEPT` call. Once the allocator is updated successfully, we
> handle subsequent operations as follows:
>
> 1) Launch or Launch Group: We launch the tasks or task group on the
> agent.
> 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send
> the `CheckPointResourcesMessage` to the agent.
>
> If allocation for any of the operations fail, those resources are not
> recovered from the allocator.
>
>
> Diffs
> -----
>
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
>
>
> Diff: https://reviews.apache.org/r/58486/diff/4/
>
>
> Testing
> -------
>
> Tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>