You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 13:11:02 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15650: [Refactor](pipeline) refactor the code of channel buffer limit and change the default value

github-actions[bot] commented on code in PR #15650:
URL: https://github.com/apache/doris/pull/15650#discussion_r1062459152


##########
be/test/vec/runtime/vdata_stream_test.cpp:
##########
@@ -130,11 +130,10 @@ TEST_F(VDataStreamTest, BasicTest) {
     TUniqueId uid;
     PlanNodeId nid = 1;
     int num_senders = 1;
-    int buffer_size = 1024 * 1024;
     RuntimeProfile profile("profile");
     bool is_merge = false;
     std::shared_ptr<QueryStatisticsRecvr> statistics = std::make_shared<QueryStatisticsRecvr>();
-    auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders, buffer_size,
+    auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders,

Review Comment:
   warning: '_instance' is a private member of 'doris::vectorized::VDataStreamTest' [clang-diagnostic-error]
   ```cpp
       auto recv = _instance.create_recvr(&runtime_stat, row_desc, uid, nid, num_senders,
                   ^
   ```
   **be/test/vec/runtime/vdata_stream_test.cpp:103:** declared private here
   ```cpp
       VDataStreamMgr _instance;
                      ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org