You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/07/02 17:44:51 UTC
[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity
prashantwason commented on a change in pull request #2701:
URL: https://github.com/apache/hudi/pull/2701#discussion_r663166378
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java
##########
@@ -350,11 +350,8 @@ public void testInstantFilenameOperations() {
assertEquals(HoodieTimeline.getCommitFromCommitFile(instantInflight.getFileName()), "5");
assertEquals(HoodieTimeline.getCommitFromCommitFile(instantComplete.getFileName()), "5");
- assertEquals(HoodieTimeline.makeFileNameAsComplete(instantInflight.getFileName()),
- instantComplete.getFileName());
-
- assertEquals(HoodieTimeline.makeFileNameAsInflight(instantComplete.getFileName()),
- instantInflight.getFileName());
+ assertEquals(instantInflight.getFileName(), instantComplete.getFileName());
Review comment:
These two asserts seem equal to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org