You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/09 09:19:21 UTC
[GitHub] [openwhisk-package-kafka] jbampton opened a new pull request #377: chore: fix spelling and grammar
jbampton opened a new pull request #377:
URL: https://github.com/apache/openwhisk-package-kafka/pull/377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-package-kafka] rabbah merged pull request #377: chore: fix spelling and grammar
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #377:
URL: https://github.com/apache/openwhisk-package-kafka/pull/377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-package-kafka] rabbah commented on a change in pull request #377: chore: fix spelling and grammar
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #377:
URL: https://github.com/apache/openwhisk-package-kafka/pull/377#discussion_r590299769
##########
File path: docs/arch/README.md
##########
@@ -30,13 +30,13 @@
4. Developer creates trigger `trigger1` on OpenWhisk, the trigger stores the annotation `feed` with the feedAction name from system package or binded package.(`/whisk.system/messagingWeb/messageHubFeed`).
5. Developer invokes action feedAction to create trigger feed passing input parameters (lifeCycle:`CREATE`, `trigger1`, Credentials1, Options:`topic1`)
6. The feedAction invokes feedWebAction forwarding input parameter.
-7. The feedWebAction inserts trigger feed doc into DB for worker group 0 (feedWebAction protects DB credentials)
+7. The feedWebAction inserts trigger feed doc into the DB for worker group 0 (feedWebAction protects DB credentials)
8. DB insertion notifies workers group 0 via Cloudant/CouchDB changes API, workers listen on DB view with a filter for their group `worker0` and gets the DB doc.
9. Kafka Consumer is created on each worker in a consumer group and starts polling for messages on `topic1` from `instance1` using `Credentials-1`.
10. Developer creates `rule1` indicating that when `trigger1` fires invoke `action1`.
11. Event source produces messages on `topic1`.
12. Both consumers will batch the messages from `topic1` and fire `trigger1`.
- - The fire is done with an http request containing the batch of messages in the body.
+ - The fire is done with a http request containing the batch of messages in the body.
Review comment:
The “an” here is correct. The h in http is “ eych”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org