You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 12:43:39 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7458: ARROW-9122: [C++] Properly handle sliced arrays in ascii_lower, ascii_upper kernels

wesm commented on a change in pull request #7458:
URL: https://github.com/apache/arrow/pull/7458#discussion_r441514953



##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -56,12 +56,14 @@ TYPED_TEST(TestStringKernels, AsciiLength) {
                    "[3, null, 0, 1]");
 }
 
-TYPED_TEST(TestStringKernels, DISABLED_AsciiUpper) {
+TYPED_TEST(TestStringKernels, AsciiUpper) {
+  this->CheckUnary("ascii_upper", "[]", this->string_type(), "[]");

Review comment:
       It does now -- @bkietz added this in ARROW-971




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org